[Impeller] Use device property uniform aligment instead of conservative value of 256. #166884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2025 15:36
added 2 commits
April 9, 2025 16:15
matanlurey
approved these changes
Apr 10, 2025
Contributor
|
autosubmit label was removed for flutter/flutter/166884, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…conservative value of 256. (flutter/flutter#166884)
| } | ||
|
|
||
| size_t CapabilitiesGLES::GetMinimumUniformAlignment() const { | ||
| return 256; |
Member
There was a problem hiding this comment.
You probably meant to do this in a followup patch. But if not, the general idea is an ivar initialized only on ES 3.0 (where UBO use is possible) with the value of glGet*(GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT) and 1u elsewhere since the uniform uploads are by copy with glUniform*.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…conservative value of 256. (flutter/flutter#166884)
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…ve value of 256. (flutter#166884) Fixes flutter#132178 Rather than 256, use the device limits which may be substantially less. Metal uses existing values and GLES still uses 256.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…conservative value of 256. (flutter/flutter#166884)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…conservative value of 256. (flutter/flutter#166884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132178
Rather than 256, use the device limits which may be substantially less. Metal uses existing values and GLES still uses 256.