这是indexloc提供的服务，不要输入任何密码
Skip to content

[Impeller] fix image shader matrix to 3x3. #166612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

[Impeller] fix image shader matrix to 3x3. #166612

merged 2 commits into from
Apr 9, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 4, 2025 •
edited
Loading

Fixes #165205

Our users expect image shader matrices to be converted to 3x3

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 4, 2025
@jonahwilliams jonahwilliams marked this pull request as ready for review April 4, 2025 22:36
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 8, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166612 at sha a4efa3f

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 8, 2025
@jonahwilliams jonahwilliams requested a review from flar April 8, 2025 17:45
@jonahwilliams jonahwilliams changed the title [Impeller] fix image shader texture to 3x3. [Impeller] fix image shader matrix to 3x3. Apr 8, 2025
flar
flar approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the general principal, this is used to map the UV coordinates for texture sampling which is an inverse transform (see ColorSourceContents.SetEffectTransform) which means if we maintain the full perspective transform then we are asking where points on the plane come from and the answer is "somewhere in space".

If this happens with other ColorSources then we should implement it for all of them, perhaps in the SetEffectTransform call itself.

Otherwise, pending further investigation, the base concept is approved.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Apr 9, 2025

I think there is a similar issue for the gradients, but they may need an additional change to funciton properly. I'm going to start with this one.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2025
Merged via the queue into flutter:master with commit 7ab8ce9 Apr 9, 2025
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
6a52ca4 
…#166612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
8b529b4 
…#166612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
bf19b47 
…#166612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
76a8bfb 
…#166612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
ea93789 
…#166612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
22b5f6c 
…#166612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
8305df3 
…#166612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
2cafe93 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
4c7ed36 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
5f09ab8 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
af58857 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
d780db5 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
5fd804f 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
e2c2ae4 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
186c7df 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
eb1dfbe 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
9f0ac14 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
051b312 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
e166aa6 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
54ba8fd 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
b77f549 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
423b663 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
dc5613d 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
1ba7997 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
6380c3e 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
74bbf3d 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
1cef859 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
d38b2d3 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
4cdc1a5 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
c0a52fd 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
9075b6b 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
8e504ae 
…#166612)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] fix image shader matrix to 3x3. (flutter#166612)
3c28052 
Fixes flutter#165205

Our users expect image shader matrices to be converted to 3x3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
64f0ba6 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
309b2cb 
…#166612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
7ab8ce963 [Impeller] fix image shader matrix to 3x3. (flutter/flutter…
27ff691 
…#166612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flar flar flar approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Impeller inconsistency when using ImageShader in CustomPaint

2 participants

@jonahwilliams @flar