-
Notifications
You must be signed in to change notification settings - Fork 29.5k
✨ Introduces PositionedGestureDetails
#160714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Introduces PositionedGestureDetails
#160714
Conversation
a13e863 to
efb7cae
Compare
|
The request was shaped and we can discuss the idea before it gets completely ready. This is similar to the previous request #101665 |
|
@AlexV525 thanks for contributing! Go ahead and hit the "Ready for review" button when it's ready for review :) |
Previously @goderbauer had an opposite opinion in adding this abstraction #101665 (comment). I'd like to hear from others before we go further and add tests for it. EDIT: Tests were added. |
nate-thegrate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! I just have a few bits of feedback, mostly relating to Diagnosticable stuff.
I'm a huge fan of this API, for reasons described in the linked issue.
packages/flutter/test/gestures/details_with_positions_test.dart
Outdated
Show resolved
Hide resolved
nate-thegrate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
I found a few more properties to change; after which this PR will be ready to merge IMO.
I used to think they were not my updates, I just realized I changed them 🤣 |
nate-thegrate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Given this comment:
I'd like to ask you wait for @goderbauer to review the PR before landing it. Thank you. |
Resolves flutter#101530 `PositionedGestureDetails` is an abstract interface that is meant to contain positions for pointer events. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Resolves #101530
PositionedGestureDetailsis an abstract interface that is meant to contain positions for pointer events.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.