[Embedder] Implement merged platform and UI thread #162944

knopp · 2025-02-08T21:40:19Z

Introduces ui_task_runner field on FlutterCustomTaskRunners. This lets the embedder to specify task runner for UI isolate tasks, allowing for merging platform and UI threads.

With custom UI task runner there is no MessageLoop anymore for the UI thread, so the message loop task observer can no longer be used to flush microtask queue. Instead the microtask queue is flushed at the end of each FlutterEngineRunTask invocation if needed. This is handled internally by the embedder.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

knopp · 2025-02-08T21:43:03Z

This is prerequisite for #162671, #162883, and #162935.

chinmaygarde · 2025-02-10T04:43:09Z

From the conversation here, the direction we want to take is to not make this be an embedder concern. As I understand, this is needed for the WIP prototype to work. Are you looking for a review here over just the implementation of a separate platform task runner configuration exposed via the embedder API?

knopp · 2025-02-10T07:29:40Z

@chinmaygarde, the concern here was about embedder API changes needed to flush microtask queue. That is gone in this PR. It is handled internally and does not leak into the API.

The only API addition is the merged_platform_ui_thread on FlutterCustomTaskRunners, which will make the UI isolate tasks executed on platform task runner. This PR ready for review. I made this a separate PR as I thought it would be cleaner than just merging together with one of the desktop PRs, but that's also an option.

knopp · 2025-02-10T08:00:05Z

Now thinking about it a bit, maybe rather than introducing merged_platform_ui_thread it would be better to simply add ui_task_runner inside FlutterCustomTaskRunners. That would reduce the assumptions made in the engine about the threading model. I'll look into this.

knopp · 2025-02-10T10:27:08Z

I have modified the PR to allow specifying ui_task_runner inside FlutterCustomTaskRunners instead of a boolean.

jonahwilliams

LGTM

engine/src/flutter/shell/platform/embedder/embedder_engine.cc

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

chinmaygarde · 2025-02-10T17:26:27Z

I have modified the PR to allow specifying ui_task_runner inside FlutterCustomTaskRunners instead of a boolean.

Thank you. That is much more preferable as it lines up identically with how the other runners are specified. Can you also add a test that tests the embedder specifying a UI task runner that is not in a merged configuration (like its own thread)?

chinmaygarde

Thanks.

auto-submit · 2025-02-10T20:25:03Z

autosubmit label was removed for flutter/flutter/162944, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-02-10T21:01:27Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162944 at sha 17d2402

loic-sharma · 2025-02-11T00:13:22Z

engine/src/flutter/fml/message_loop_task_queues.cc

@@ -17,6 +17,7 @@
 namespace fml {

 const size_t TaskQueueId::kUnmerged = ULONG_MAX;
+const size_t TaskQueueId::kInvalid = ULONG_MAX - 1;


What do you think of calling this something like kNone and renaming TaskQueueId::is_valid to TaskQueueId::exists?

I worry we might be tempted to reuse the "invalid" state for more than "This task runner does not have its own task queue". I don't feel strongly about this, feel free to skip

engine/src/flutter/shell/common/engine.h

loic-sharma · 2025-02-11T00:18:19Z

engine/src/flutter/fml/task_runner.h

@@ -55,6 +55,9 @@ class TaskRunner : public fml::RefCountedThreadSafe<TaskRunner>,

  /// Returns the unique identifier associated with the TaskRunner.
  /// \see fml::MessageLoopTaskQueues
+  ///
+  /// Will be TaskQueueId::kInvalid for embedder supplied task runners
+  /// that are not associated with a task queue.
  virtual TaskQueueId GetTaskQueueId();


I worry people will forget to check the TaskQueueId::kInvalid case everywhere. Would it make sense to make this return a std::optional<TaskQueueId> and return std::nullopt if the runner has no associated task queue?

I don't feel strongly about this, feel free to skip

I'll make a follow-up PR with this change. I feel like that's going to add a bit of noise so maybe a separate PR will be better.

loic-sharma · 2025-02-11T00:19:34Z

engine/src/flutter/shell/platform/embedder/embedder.cc

+    if (has_ui_thread_message_loop) {
+      fml::MessageLoop::GetCurrent().RemoveTaskObserver(key);
+    }
+  };


Just for my own curiosity, what are the task observers used for? I don't understand the implications of not registering these observers

Ah from the comment in EmbedderEngine::RunTask, it sounds like the observers are used to flush microtasks?

If so, what do you think adding a quick comment here to explain that this is used to flush microtasks if there's a separate UI thread, otherwise, microtasks are flushed by EmbedderEngine::RunTask?

engine/src/flutter/shell/platform/embedder/embedder_engine.cc

…lutter#162944)

Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...

…lutter#162944)

Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...

github-actions bot added the engine flutter/engine repository. See also e: labels. label Feb 8, 2025

knopp requested review from chinmaygarde and jonahwilliams February 8, 2025 21:40

knopp force-pushed the embedder_merged_ui_thread branch 2 times, most recently from 2f7e60a to 6ef97ff Compare February 10, 2025 10:21

[Embedder] Implement merged platform and UI thread

8cd39c9

knopp force-pushed the embedder_merged_ui_thread branch from 6ef97ff to 8cd39c9 Compare February 10, 2025 13:43

jonahwilliams approved these changes Feb 10, 2025

View reviewed changes

engine/src/flutter/shell/platform/embedder/embedder_engine.cc Outdated Show resolved Hide resolved

Update engine/src/flutter/shell/platform/embedder/embedder_engine.cc

e85d6da

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

Cleanup tests

180ad5c

chinmaygarde approved these changes Feb 10, 2025

View reviewed changes

Add tests

17d2402

knopp force-pushed the embedder_merged_ui_thread branch from 0e462a2 to 17d2402 Compare February 10, 2025 18:36

knopp added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 10, 2025

loic-sharma reviewed Feb 11, 2025

View reviewed changes

engine/src/flutter/shell/common/engine.h Outdated Show resolved Hide resolved

loic-sharma reviewed Feb 11, 2025

View reviewed changes

engine/src/flutter/shell/platform/embedder/embedder_engine.cc Outdated Show resolved Hide resolved

knopp mentioned this pull request Feb 11, 2025

[windows] Implement merged UI and platform thread #162935

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Feb 12, 2025

Roll Flutter from 892f9c13a2bb to cdce7658473f (70 revisions) flutter/packages#8612

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

fa45bdc

…lutter#162944)

engine-flutter-autoroll mentioned this pull request Feb 12, 2025

Roll Flutter from 892f9c13a2bb to e8f34a9eea90 (71 revisions) flutter/packages#8614

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

db41241

…lutter#162944)

engine-flutter-autoroll mentioned this pull request Feb 12, 2025

Roll Flutter from 892f9c13a2bb to 90a4323cab4e (72 revisions) flutter/packages#8616

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

0e0b76e

…lutter#162944)

engine-flutter-autoroll mentioned this pull request Feb 12, 2025

Roll Flutter from 892f9c13a2bb to 09fdf159b911 (74 revisions) flutter/packages#8617

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

91b360e

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

a5dbf48

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

b38a332

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

c479258

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

908dfd5

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

f1394a0

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

6970889

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

3ade3b2

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

0d0bc26

…lutter#162944)

Piinks mentioned this pull request Feb 14, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

ac8cd56

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

86ffbab

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

09826e7

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

60d03a2

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

4272afd

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

574dff5

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

5fa14ca

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

68f3518

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

f986a23

…lutter#162944)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

94cd4b1 [Embedder] Implement merged platform and UI thread (flutter/f…

182def2

…lutter#162944)

[Embedder] Implement merged platform and UI thread #162944

[Embedder] Implement merged platform and UI thread #162944

Uh oh!

Conversation

knopp commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

knopp commented Feb 8, 2025

Uh oh!

chinmaygarde commented Feb 10, 2025

Uh oh!

knopp commented Feb 10, 2025

Uh oh!

knopp commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

knopp commented Feb 10, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chinmaygarde commented Feb 10, 2025

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 10, 2025

Uh oh!

flutter-dashboard bot commented Feb 10, 2025

Uh oh!

loic-sharma Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

loic-sharma Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

knopp Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

knopp commented Feb 8, 2025 •

edited

Loading

knopp commented Feb 10, 2025 •

edited

Loading

loic-sharma Feb 11, 2025 •

edited

Loading