这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: RangeError when selecting text in SelectionArea #162228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 5, 2025
Merged

fix: RangeError when selecting text in SelectionArea #162228

merged 7 commits into from
Feb 5, 2025

Conversation

rkishan516
Copy link
Contributor

fix: RangeError when selecting text in SelectionArea
fixes #161931

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 26, 2025
@rkishan516 rkishan516 force-pushed the selection-area-text-range-overflow branch from 45eeaf3 to a552fe8 Compare January 26, 2025 11:23
@rkishan516 rkishan516 force-pushed the selection-area-text-range-overflow branch 2 times, most recently from 1705c8e to 5945484 Compare February 1, 2025 02:18
@rkishan516 rkishan516 force-pushed the selection-area-text-range-overflow branch from 5945484 to 3cdbf2a Compare February 1, 2025 02:18
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162228 at sha 3cdbf2a

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 1, 2025
Renzo-Olivares
Renzo-Olivares approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@goderbauer goderbauer requested a review from chunhtai February 4, 2025 23:08
chunhtai
chunhtai approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into flutter:master with commit 211d83d Feb 5, 2025
75 of 76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
3600e92 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
07bfa61 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
b1010db 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
a8cc4c3 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
d890c84 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
23b02df 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
a96e400 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
7628fcb 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
8a8afc6 
…er/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
28c70e6 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
2215bf5 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
5fb9edd 
…/flutter#162228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
de773f5 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
eda3a9a 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
4764bbb 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
6d2a2ee 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
1692b5b 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
2408d8d 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
82f3ea8 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
c20c7c7 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
ea95125 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
c82a727 
…/flutter#162228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
211d83d fix: RangeError when selecting text in SelectionArea (flutter…
267c7c2 
…/flutter#162228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RangeError when selecting text in SelectionArea
3 participants
@rkishan516 @Renzo-Olivares @chunhtai