Add action for configuring default action of EditableText.onTapUpOutside #162575

Hannnes1 · 2025-02-02T11:51:11Z

This PR adds an Action for configuring a default action of EditableText.onTapUpOutside. This is the equivalent to what #150125 did for EditableText.onTapOutside.

Fixes #162212

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

justinmc

LGTM with nits 👍 . Thanks for jumping on this PR.

packages/flutter/lib/src/widgets/text_editing_intents.dart

justinmc · 2025-02-04T18:56:14Z

packages/flutter/test/widgets/editable_text_test.dart

+    );
+    await tester.pump();
+    await tester.tap(find.byKey(key), warnIfMissed: false);
+    await tester.pumpAndSettle();


Nit: If this works with pump instead of pumpAndSettle, I would switch to that in order to have less uncertainty in the test.

I copied this from the onTapOutside test (the test just above this one), but when running it locally I'm not sure if the pump there is needed at all.

justinmc · 2025-02-04T18:57:32Z

examples/api/lib/widgets/text_editing_intents/editable_text_tap_up_outside_intent.0.dart

This is a good, practical example, thanks for adding it!

Thanks you!

Hannnes1 · 2025-02-05T09:58:43Z

Had some issues with the tests, but it seems like I managed to solve that now

justinmc

Renewing my LGTM 👍 . I'll try to find a second reviewer.

justinmc · 2025-02-18T19:26:27Z

examples/api/lib/widgets/text_editing_intents/editable_text_tap_up_outside_intent.0.dart

+          child: ListView(
+            children: <Widget>[
+              TextField(focusNode: FocusNode()),
+              ...List<Widget>.generate(50, (int index) => Text('Item $index')),


Nit: This might be better as a ListView.builder since you are using List.generate? But either way is fine.

justinmc · 2025-02-18T19:29:11Z

packages/flutter/test/widgets/editable_text_test.dart

+        ),
+      ),
+    );
+    await tester.pump();


Nit: Is this pump necessary?

victorsanni

Thanks for the PR. I left some small documentation nits.

examples/api/lib/widgets/text_editing_intents/editable_text_tap_up_outside_intent.0.dart

packages/flutter/lib/src/widgets/editable_text.dart

justinmc · 2025-02-26T00:11:32Z

@Hannnes1 Heads up there is an analyzer failure.

This test is copied from the test for onTapOutside. That test changes the unfocusing behaviour, and therefore verifies that. I had erroneously left that check in my test, even if it doesn't change the default unfocusing behaviour.

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>

Hannnes1 · 2025-02-27T08:19:09Z

Thanks @justinmc. Seems like it was a flaky test or something. Rebased master again, and everything passes now.

…apUpOutside (flutter/flutter#162575)

Roll Flutter from 2e570ca to 842db35 (59 revisions) flutter/flutter@2e570ca...842db35 2025-03-02 engine-flutter-autoroll@skia.org Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449) 2025-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440) 2025-03-02 chris@bracken.jp android: Clean up gen_snapshot artifact build (flutter/flutter#164418) 2025-03-02 matanlurey@users.noreply.github.com Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352) 2025-03-01 chris@bracken.jp Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410) 2025-03-01 chris@bracken.jp Delete unused build archive targets (flutter/flutter#164414) 2025-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423) 2025-03-01 engine-flutter-autoroll@skia.org Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413) 2025-03-01 eric@shorebird.dev Update linux_host_engine.json ci/host_release description (flutter/flutter#164402) 2025-03-01 jason-simmons@users.noreply.github.com In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395) 2025-03-01 matanlurey@users.noreply.github.com Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401) 2025-02-28 ybz975218925@gmail.com Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731) 2025-02-28 engine-flutter-autoroll@skia.org Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404) 2025-02-28 matej.knopp@gmail.com [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962) 2025-02-28 matej.knopp@gmail.com Add PlatformDispatcher.engineId (flutter/flutter#163476) 2025-02-28 matanlurey@users.noreply.github.com Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398) 2025-02-28 34465683+rkishan516@users.noreply.github.com Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853) 2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396) 2025-02-28 47989573+Hannnes1@users.noreply.github.com Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575) 2025-02-28 reidbaker@google.com Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200) 2025-02-28 engine-flutter-autoroll@skia.org Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380) 2025-02-28 51940183+Sameri11@users.noreply.github.com [tool] Allow using archiveName in android bundle build (flutter/flutter#162390) 2025-02-28 ueman@users.noreply.github.com Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101) 2025-02-28 robert.ancell@canonical.com Support forward and back buttons (flutter/flutter#164356) 2025-02-28 robert.ancell@canonical.com Fix window creation callback for multi-window (flutter/flutter#164353) 2025-02-28 robert.ancell@canonical.com Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334) 2025-02-28 sigurdm@google.com Refactor writing of package config in tests (flutter/flutter#163734) 2025-02-28 ybz975218925@gmail.com Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996) 2025-02-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#164357) 2025-02-28 codefu@google.com Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350) 2025-02-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351) 2025-02-28 ybz975218925@gmail.com Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723) 2025-02-28 jonahwilliams@google.com [Android] Use java for looking up Android API level. (flutter/flutter#163558) 2025-02-28 matanlurey@users.noreply.github.com Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317) 2025-02-27 47866232+chunhtai@users.noreply.github.com Wires up expanded state in web engine (flutter/flutter#164048) 2025-02-27 matanlurey@users.noreply.github.com Remove Cheserton's File (flutter/flutter#164340) 2025-02-27 robert.ancell@canonical.com Replace update semantics handler with signal. (flutter/flutter#163583) 2025-02-27 30870216+gaaclarke@users.noreply.github.com Split up the conical gradient fragment shader (flutter/flutter#164058) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339) 2025-02-27 matanlurey@users.noreply.github.com Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324) 2025-02-27 matanlurey@users.noreply.github.com Document how `engine.version` (is/will be) computed (flutter/flutter#164335) 2025-02-27 christopherfujino@gmail.com Update conductor to write engine.version file (flutter/flutter#163350) 2025-02-27 reidbaker@google.com remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198) 2025-02-27 matanlurey@users.noreply.github.com Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328) 2025-02-27 34871572+gmackall@users.noreply.github.com Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233) 2025-02-27 aam@google.com Revert dart sdks that were causing dartaotruntime issues in g3 (flutter/flutter#164307) ...

…apUpOutside (flutter/flutter#162575)

Roll Flutter from 2e570ca to 842db35 (59 revisions) flutter/flutter@2e570ca...842db35 2025-03-02 engine-flutter-autoroll@skia.org Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449) 2025-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440) 2025-03-02 chris@bracken.jp android: Clean up gen_snapshot artifact build (flutter/flutter#164418) 2025-03-02 matanlurey@users.noreply.github.com Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352) 2025-03-01 chris@bracken.jp Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410) 2025-03-01 chris@bracken.jp Delete unused build archive targets (flutter/flutter#164414) 2025-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423) 2025-03-01 engine-flutter-autoroll@skia.org Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413) 2025-03-01 eric@shorebird.dev Update linux_host_engine.json ci/host_release description (flutter/flutter#164402) 2025-03-01 jason-simmons@users.noreply.github.com In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395) 2025-03-01 matanlurey@users.noreply.github.com Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401) 2025-02-28 ybz975218925@gmail.com Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731) 2025-02-28 engine-flutter-autoroll@skia.org Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404) 2025-02-28 matej.knopp@gmail.com [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962) 2025-02-28 matej.knopp@gmail.com Add PlatformDispatcher.engineId (flutter/flutter#163476) 2025-02-28 matanlurey@users.noreply.github.com Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398) 2025-02-28 34465683+rkishan516@users.noreply.github.com Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853) 2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396) 2025-02-28 47989573+Hannnes1@users.noreply.github.com Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575) 2025-02-28 reidbaker@google.com Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200) 2025-02-28 engine-flutter-autoroll@skia.org Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380) 2025-02-28 51940183+Sameri11@users.noreply.github.com [tool] Allow using archiveName in android bundle build (flutter/flutter#162390) 2025-02-28 ueman@users.noreply.github.com Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101) 2025-02-28 robert.ancell@canonical.com Support forward and back buttons (flutter/flutter#164356) 2025-02-28 robert.ancell@canonical.com Fix window creation callback for multi-window (flutter/flutter#164353) 2025-02-28 robert.ancell@canonical.com Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334) 2025-02-28 sigurdm@google.com Refactor writing of package config in tests (flutter/flutter#163734) 2025-02-28 ybz975218925@gmail.com Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996) 2025-02-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#164357) 2025-02-28 codefu@google.com Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350) 2025-02-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351) 2025-02-28 ybz975218925@gmail.com Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723) 2025-02-28 jonahwilliams@google.com [Android] Use java for looking up Android API level. (flutter/flutter#163558) 2025-02-28 matanlurey@users.noreply.github.com Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317) 2025-02-27 47866232+chunhtai@users.noreply.github.com Wires up expanded state in web engine (flutter/flutter#164048) 2025-02-27 matanlurey@users.noreply.github.com Remove Cheserton's File (flutter/flutter#164340) 2025-02-27 robert.ancell@canonical.com Replace update semantics handler with signal. (flutter/flutter#163583) 2025-02-27 30870216+gaaclarke@users.noreply.github.com Split up the conical gradient fragment shader (flutter/flutter#164058) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339) 2025-02-27 matanlurey@users.noreply.github.com Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324) 2025-02-27 matanlurey@users.noreply.github.com Document how `engine.version` (is/will be) computed (flutter/flutter#164335) 2025-02-27 christopherfujino@gmail.com Update conductor to write engine.version file (flutter/flutter#163350) 2025-02-27 reidbaker@google.com remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198) 2025-02-27 matanlurey@users.noreply.github.com Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328) 2025-02-27 34871572+gmackall@users.noreply.github.com Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233) 2025-02-27 aam@google.com Revert dart sdks that were causing dartaotruntime issues in g3 (flutter/flutter#164307) ...

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Feb 2, 2025

justinmc approved these changes Feb 4, 2025

View reviewed changes

justinmc requested review from Renzo-Olivares and victorsanni February 13, 2025 21:46

justinmc approved these changes Feb 18, 2025

View reviewed changes

victorsanni approved these changes Feb 19, 2025

View reviewed changes

Hannnes1 force-pushed the tap-up-config branch from 02f52f9 to cb1601e Compare February 20, 2025 18:07

Hannnes1 force-pushed the tap-up-config branch 2 times, most recently from a0f3bc8 to aea50ea Compare February 26, 2025 21:02

Hannnes1 and others added 9 commits February 27, 2025 08:22

Add action for onTapUpOutside

aa2f2dc

Add test

1a4543d

Add example

7332620

Fix formatting

0aa24a7

Add line break to comment

90e0be8

Minor test change

8f5c158

Remove duplicate MaterialApp from example

3f43769

Fix failing test on web

07e7ae5

This test is copied from the test for onTapOutside. That test changes the unfocusing behaviour, and therefore verifies that. I had erroneously left that check in my test, even if it doesn't change the default unfocusing behaviour.

Apply suggestions from code review

3235327

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>

Hannnes1 force-pushed the tap-up-config branch from aea50ea to 3235327 Compare February 27, 2025 07:22

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025

auto-submit bot added this pull request to the merge queue Feb 28, 2025

Merged via the queue into flutter:master with commit 6958d08 Feb 28, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025

Hannnes1 deleted the tap-up-config branch March 1, 2025 08:29

engine-flutter-autoroll mentioned this pull request Mar 1, 2025

Roll Flutter from 2e570ca393c8 to 0c055f2c508a (55 revisions) flutter/packages#8767

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025

6958d08 Add action for configuring default action of EditableText.onT…

7364b04

…apUpOutside (flutter/flutter#162575)

engine-flutter-autoroll mentioned this pull request Mar 1, 2025

Roll Flutter from 2e570ca393c8 to 0c055f2c508a (55 revisions) flutter/packages#8768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025

6958d08 Add action for configuring default action of EditableText.onT…

b60545e

…apUpOutside (flutter/flutter#162575)

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 619d4248114d (58 revisions) flutter/packages#8769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

6958d08 Add action for configuring default action of EditableText.onT…

b53765d

…apUpOutside (flutter/flutter#162575)

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 842db35d27b8 (59 revisions) flutter/packages#8770

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

6958d08 Add action for configuring default action of EditableText.onT…

3a4f858

…apUpOutside (flutter/flutter#162575)

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 842db35d27b8 (59 revisions) flutter/packages#8771

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

6958d08 Add action for configuring default action of EditableText.onT…

3d485fc

…apUpOutside (flutter/flutter#162575)

Piinks mentioned this pull request Mar 7, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

6958d08 Add action for configuring default action of EditableText.onT…

bef4dc6

…apUpOutside (flutter/flutter#162575)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

6958d08 Add action for configuring default action of EditableText.onT…

0e62148

…apUpOutside (flutter/flutter#162575)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

6958d08 Add action for configuring default action of EditableText.onT…

b9ee8de

…apUpOutside (flutter/flutter#162575)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add action for configuring default action of EditableText.onTapUpOutside #162575

Add action for configuring default action of EditableText.onTapUpOutside #162575

Uh oh!

Hannnes1 commented Feb 2, 2025

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

justinmc Feb 4, 2025

Uh oh!

Hannnes1 Feb 4, 2025

Uh oh!

justinmc Feb 4, 2025

Uh oh!

Hannnes1 Feb 4, 2025

Uh oh!

Hannnes1 commented Feb 5, 2025

Uh oh!

justinmc left a comment

Uh oh!

justinmc Feb 18, 2025

Uh oh!

justinmc Feb 18, 2025

Uh oh!

victorsanni left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinmc commented Feb 26, 2025

Uh oh!

Hannnes1 commented Feb 27, 2025

Uh oh!

Uh oh!

Uh oh!

Add action for configuring default action of EditableText.onTapUpOutside #162575

Add action for configuring default action of EditableText.onTapUpOutside #162575

Uh oh!

Conversation

Hannnes1 commented Feb 2, 2025

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Hannnes1 Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Hannnes1 Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Hannnes1 commented Feb 5, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinmc commented Feb 26, 2025

Uh oh!

Hannnes1 commented Feb 27, 2025

Uh oh!

Uh oh!

Uh oh!