WIP #155796
Closed
WIP #155796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c860bde to
67d559d
Compare
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…roid (#155800) This is a follow-up to the PR #155049 (which fixed #154903). This PR addresses the resulting issue, #155795. It does so in a hacky way for the sake of simplicity (and thus suitability for cherry-picking). I intend to clean this up on the master channel with yet another follow-up PR, #155796, which currently exists as a proof-of-concept to make sure I actually have the ability to clean this after myself here. **I intend to submit a stable hotfix patch with the changes from the original fix (#154903) and the follow-up changes from this PR.**
andrewkolos
added a commit
to andrewkolos/flutter
that referenced
this pull request
Sep 30, 2024
…roid (flutter#155800) This is a follow-up to the PR flutter#155049 (which fixed flutter#154903). This PR addresses the resulting issue, flutter#155795. It does so in a hacky way for the sake of simplicity (and thus suitability for cherry-picking). I intend to clean this up on the master channel with yet another follow-up PR, flutter#155796, which currently exists as a proof-of-concept to make sure I actually have the ability to clean this after myself here. **I intend to submit a stable hotfix patch with the changes from the original fix (flutter#154903) and the follow-up changes from this PR.**
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Oct 1, 2024
…roid (flutter#155800) This is a follow-up to the PR flutter#155049 (which fixed flutter#154903). This PR addresses the resulting issue, flutter#155795. It does so in a hacky way for the sake of simplicity (and thus suitability for cherry-picking). I intend to clean this up on the master channel with yet another follow-up PR, flutter#155796, which currently exists as a proof-of-concept to make sure I actually have the ability to clean this after myself here. **I intend to submit a stable hotfix patch with the changes from the original fix (flutter#154903) and the follow-up changes from this PR.**
67d559d to
80c28e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155795
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.