Use flutter from in same repo (not path) in generate_gradle_lockfiles.dart (again)
#155794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: Tested by running on CI. |
|
This particular test seems to be running into an infra failure frequently: Looks like it is particularly this bot |
|
auto label is removed for flutter/flutter/155794, due to - The status or check suite Windows module_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/flutter/155794, due to - The status or check suite Mac_x64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label. |
reidbaker
approved these changes
Sep 27, 2024
|
@gmackall consider filing a bug against our team to write a longer for this class of mistake. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Turns the roller bot back on, as it should have been fixed by #155794.
Merged
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 7, 2024
Manual roll requested by stuartmorgan@google.com flutter/flutter@fa402c8...ead6b0d 2024-09-27 kustermann@google.com Remove left-over traces of "link-dry-run" - which isn't used anywhere in flutter (flutter/flutter#155820) 2024-09-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 revisions) (flutter/flutter#155811) 2024-09-27 bruno.leroux@gmail.com Fix DropdownMenu rendered behind AppBar (flutter/flutter#155539) 2024-09-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 revisions) (flutter/flutter#155799) 2024-09-27 ditman@gmail.com Throw StateError when implicitView is null on `wrapWithDefaultView`. (flutter/flutter#155734) 2024-09-27 34871572+gmackall@users.noreply.github.com Roll packages manually (flutter/flutter#155786) 2024-09-27 rmolivares@renzo-olivares.dev fix: SelectableText should handle focus changes (flutter/flutter#155771) 2024-09-27 34871572+gmackall@users.noreply.github.com Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (again) (flutter/flutter#155794) 2024-09-26 34871572+gmackall@users.noreply.github.com Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (flutter/flutter#155790) 2024-09-26 rmolivares@renzo-olivares.dev `RenderParagraph` should invalidate its `_SelectableFragment`s cached rects on window size updates (flutter/flutter#155719) 2024-09-26 zeqinjie@qq.com Fix broken text field with set hint and min and max lines(#153183) (flutter/flutter#153235) 2024-09-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e6133e8d906 to 53517772a5b0 (1 revision) (flutter/flutter#155772) 2024-09-26 ian@hixie.ch Fix line-wrapping in `flutter create` error message. (flutter/flutter#150325) 2024-09-26 christopherfujino@gmail.com remove fujino from CODEOWNERS (flutter/flutter#155369) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…lockfiles.dart` (again) (flutter/flutter#155794)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another invocation of
flutter. Follow up to #155790.Checked that this is the only other one (and also the only use of
exec()left that is relying on the path and shouldn't be (one other use uses git from the path, which is fine, and the other one uses an absolute path).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.