integration_test: migrate to build.gradle.kts #154125

bartekpacia · 2024-08-26T17:24:26Z

Attempt to reland #142008 half a year later.

Benefit: this will be the first plugin in Flutter repo that uses Gradle KTS for Android buildscripts. Once it works fine, we can follow up with migration of more plugins later.

The previous error message was:

e: /b/s/w/ir/cache/gradle/caches/jars-8/42139b5be0c79e133a7b5c5c5d5bf731/gradle-7.3.1.jar!/com/android/build/gradle/LibraryExtension.class: Class 'com/android/build/gradle/LibraryExtension' was compiled with an incompatible version of Kotlin. The binary version of its bytecode is unknown, expected version is 1.0.3
e: /b/s/w/ir/cache/gradle/caches/jars-8/043c0d54e2c1bb39208ec4477607cdf5/gradle-api-7.3.1.jar!/com/android/build/api/dsl/LibraryVariantDimension.class: Class 'com/android/build/api/dsl/LibraryVariantDimension' was compiled with an incompatible version of Kotlin. The binary version of its bytecode is unknown, expected version is 1.0.3

FAILURE: Build failed with an exception.

* Where:
Build file '/b/s/w/ir/x/w/flutter/packages/integration_test/android/build.gradle.kts' line: 36

* What went wrong:
com.android.build.gradle.LibraryExtension.setNamespace(Ljava/lang/String;)V

The integration_test plugin now puts com.android.tools.build:gradle:8.1.0 on its classpath since #153795.

This makes me take an optimistic bet that it won't kill the autoroller now 🤞

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-08-26T17:24:29Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

goderbauer · 2024-09-10T22:11:44Z

(triage): Looks like this is making many checks fail. Can you please take a look at those?

bartekpacia · 2024-09-10T22:16:38Z

hey! Yes, I plan to do it this/next week.

got very busy recently, sorry

reidbaker · 2024-10-01T17:35:08Z

out of band comms, this is ready for review

…r#154125)

bartekpacia · 2024-10-02T16:25:47Z

i got a bad feeling about this

reidbaker · 2024-10-02T16:29:16Z

?, are you worried about post submit tests?

bartekpacia · 2024-10-02T16:31:03Z

yes

reidbaker · 2024-10-02T16:31:22Z

https://flutter-dashboard.appspot.com/#/build?hashFilter=e819a38292406ca770719656760c06a2a59b2b04&repo=flutter&branch=master

bartekpacia · 2024-10-02T16:32:19Z

Reason for revert: broke postsubmit

bartekpacia · 2024-10-02T16:33:05Z

will try to reland it asap (this week)

This reverts commit e819a38.

…r#154125)

Manual roll Flutter from 0975e61 to ec2e12b (54 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@0975e61...ec2e12b 2024-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from bd44b58e3204 to 247bc68c578e (7 revisions) (flutter/flutter#156144) 2024-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 70232fa124d0 to bd44b58e3204 (1 revision) (flutter/flutter#156124) 2024-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 33ac1b30ab0a to 70232fa124d0 (2 revisions) (flutter/flutter#156122) 2024-10-02 36861262+QuncCccccc@users.noreply.github.com Update `ThemeData.dialogTheme` type to accept `DialogThemeData` (flutter/flutter#155129) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 751ab9b3c5eb to 33ac1b30ab0a (4 revisions) (flutter/flutter#156118) 2024-10-02 aam@google.com Add back main() methods to benchmark benches. (flutter/flutter#156083) 2024-10-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156117) 2024-10-02 victorsanniay@gmail.com Add `mouseCursor` property to `CupertinoCheckbox` (flutter/flutter#151788) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3bdc1c0a30b6 to 751ab9b3c5eb (3 revisions) (flutter/flutter#156115) 2024-10-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156114) 2024-10-02 bkonyi@google.com [ Cocoon ] Wait for task results to be received by the task runner before shutting down the task process (flutter/flutter#156002) 2024-10-02 58190796+MitchellGoodwin@users.noreply.github.com Allow mixing route transitions in one app. (flutter/flutter#150031) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f20681241753 to 3bdc1c0a30b6 (5 revisions) (flutter/flutter#156107) 2024-10-02 reidbaker@google.com Update Upgrading-Engine's-Android-API-version.md to reflect code move (flutter/flutter#156108) 2024-10-02 engine-flutter-autoroll@skia.org Roll Packages from ebcc4f0 to 7c97c88 (5 revisions) (flutter/flutter#156106) 2024-10-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156105) 2024-10-02 120297255+PurplePolyhedron@users.noreply.github.com fix wrong test in "fixing `DropdownMenu` keyboard navigation" (flutter/flutter#156084) 2024-10-02 brackenavaron@gmail.com fix ReorderableList not passing in item extent builder (flutter/flutter#155994) 2024-10-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "integration_test: migrate to build.gradle.kts (#154125)" (flutter/flutter#156087) 2024-10-02 magder@google.com Add deprecation warning for "flutter create --ios-language" (flutter/flutter#155867) 2024-10-02 devoncarew@google.com update flutter create generated projects to use package:flutter_lints 5.0.0 (flutter/flutter#156011) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d48c35d16814 to f20681241753 (1 revision) (flutter/flutter#156080) 2024-10-02 captainsikandar47@gmail.com [Docs] `CupertinoListTile` API Example (flutter/flutter#154548) 2024-10-02 barpac02@gmail.com integration_test: migrate to build.gradle.kts (flutter/flutter#154125) 2024-10-02 fluttergithubbot@gmail.com Marks Windows_mokey native_assets_android to be flaky (flutter/flutter#156064) 2024-10-02 leroux_bruno@yahoo.fr Fix DropdownMenu does not rematch initialSelection when entries have changed (flutter/flutter#155757) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9b224bd2f895 to d48c35d16814 (1 revision) (flutter/flutter#156074) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8774940b9ddc to 9b224bd2f895 (1 revision) (flutter/flutter#156065) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21ad04948457 to 8774940b9ddc (1 revision) (flutter/flutter#156055) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 767bdc38cf51 to 21ad04948457 (1 revision) (flutter/flutter#156049) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 055969512dc5 to 767bdc38cf51 (1 revision) (flutter/flutter#156043) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0f049d69240 to 055969512dc5 (2 revisions) (flutter/flutter#156042) 2024-10-02 120297255+PurplePolyhedron@users.noreply.github.com fix `DropdownMenu` keyboard navigation when entries are filtered empty (flutter/flutter#155252) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from a5bc2e2708c7 to e0f049d69240 (1 revision) (flutter/flutter#156039) 2024-10-02 christopherfujino@gmail.com mark {Linux,Windows} tool_integration_tests_* non-bringup (flutter/flutter#155773) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7abf7a8163e to a5bc2e2708c7 (2 revisions) (flutter/flutter#156038) 2024-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from df1982dd4482 to a7abf7a8163e (1 revision) (flutter/flutter#156032) 2024-10-02 66697085+SuicaLondon@users.noreply.github.com Add `enableSplash` parameter to `CarouselView` (flutter/flutter#155214) 2024-10-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156030) 2024-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from ab48d6d8c167 to df1982dd4482 (1 revision) (flutter/flutter#156029) 2024-10-01 fluttergithubbot@gmail.com Marks Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark to be unflaky (flutter/flutter#147289) 2024-10-01 sokolovskyi.konstantin@gmail.com Add WidgetStateMouseCursor example and tests for it. (flutter/flutter#155552) 2024-10-01 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.5.0 to 4.6.0 (flutter/flutter#156024) 2024-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from e7b3ce717006 to ab48d6d8c167 (1 revision) (flutter/flutter#156023) ...

This PR is yet another attempt (after #154125) to reland #142008. Benefit: this will be the first plugin in Flutter repo that uses Gradle KTS for Android buildscripts. Once it works fine, we can follow up with migration of more plugins later. [The previous error message](#142008 (comment)) was: ``` e: /b/s/w/ir/cache/gradle/caches/jars-8/42139b5be0c79e133a7b5c5c5d5bf731/gradle-7.3.1.jar!/com/android/build/gradle/LibraryExtension.class: Class 'com/android/build/gradle/LibraryExtension' was compiled with an incompatible version of Kotlin. The binary version of its bytecode is unknown, expected version is 1.0.3 e: /b/s/w/ir/cache/gradle/caches/jars-8/043c0d54e2c1bb39208ec4477607cdf5/gradle-api-7.3.1.jar!/com/android/build/api/dsl/LibraryVariantDimension.class: Class 'com/android/build/api/dsl/LibraryVariantDimension' was compiled with an incompatible version of Kotlin. The binary version of its bytecode is unknown, expected version is 1.0.3 FAILURE: Build failed with an exception. * Where: Build file '/b/s/w/ir/x/w/flutter/packages/integration_test/android/build.gradle.kts' line: 36 * What went wrong: com.android.build.gradle.LibraryExtension.setNamespace(Ljava/lang/String;)V ``` The `integration_test` plugin now puts `com.android.tools.build:gradle:8.1.0` on its classpath since #153795. This makes me take an optimistic bet that it won't kill the autoroller now ð�¤�

…r#154125)

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Aug 26, 2024

bartekpacia mentioned this pull request Aug 26, 2024

Use Gradle KTS in new Android app projects by default #154061

Merged

9 tasks

bartekpacia added 2 commits September 20, 2024 22:16

integration_test: migrate to build.gradle.kts

c25725f

integration_test build.gradle.kts: minSdkVersion -> minSdk

c973af9

bartekpacia requested review from reidbaker and gmackall September 20, 2024 21:40

gmackall approved these changes Oct 1, 2024

View reviewed changes

reidbaker approved these changes Oct 2, 2024

View reviewed changes

bartekpacia added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 2, 2024

auto-submit bot merged commit e819a38 into flutter:master Oct 2, 2024
74 checks passed

engine-flutter-autoroll mentioned this pull request Oct 2, 2024

Roll Flutter from fa402c8057a1 to e819a3829240 (83 revisions) flutter/packages#7764

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

f77269d

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 2, 2024

Roll Flutter from fa402c8057a1 to ff7e5f3d736c (86 revisions) flutter/packages#7765

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

1673869

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 2, 2024

Roll Flutter from fa402c8057a1 to 22247cd55cff (87 revisions) flutter/packages#7767

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

9c6d672

…r#154125)

bartekpacia added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 2, 2024

auto-submit bot pushed a commit that referenced this pull request Oct 2, 2024

Revert "integration_test: migrate to build.gradle.kts (#154125)"

f86a447

This reverts commit e819a38.

engine-flutter-autoroll mentioned this pull request Oct 3, 2024

Roll Flutter from fa402c8057a1 to ec2e12ba5099 (106 revisions) flutter/packages#7777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

69ed8d9

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 3, 2024

Roll Flutter from fa402c8057a1 to 58e0e00c63b6 (107 revisions) flutter/packages#7778

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

153fce6

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 3, 2024

Roll Flutter from fa402c8057a1 to c8c2f4651a14 (109 revisions) flutter/packages#7779

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

cd898dc

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 3, 2024

Roll Flutter from fa402c8057a1 to 91eb8d226d75 (110 revisions) flutter/packages#7780

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

e8ef532

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 3, 2024

Roll Flutter from fa402c8057a1 to 5ecf10052fc2 (111 revisions) flutter/packages#7782

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

215d4d9

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 3, 2024

Roll Flutter from fa402c8057a1 to d39550fb528c (113 revisions) flutter/packages#7784

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

2cf908a

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 4, 2024

Roll Flutter from fa402c8057a1 to 195f81e025de (122 revisions) flutter/packages#7789

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

e8114c5

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 4, 2024

Roll Flutter from fa402c8057a1 to 85abc1a3a469 (123 revisions) flutter/packages#7791

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

fbfc9db

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 4, 2024

Roll Flutter from fa402c8057a1 to 85abc1a3a469 (123 revisions) flutter/packages#7793

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

e78bcd3

…r#154125)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

6c073eb

…r#154125)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

484274d

…r#154125)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

d198106

…r#154125)

bartekpacia deleted the integration_test_build_gradle_kts branch October 6, 2024 16:36

bartekpacia mentioned this pull request Oct 6, 2024

integration_test: migrate to build.gradle.kts #156291

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

8f91fe2

…r#154125)

engine-flutter-autoroll mentioned this pull request Oct 8, 2024

Manual roll Flutter from 0975e612c04a to ec2e12ba5099 (54 revisions) flutter/packages#7815

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

296c9c2

…r#154125)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

2781523

…r#154125)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

e819a38 integration_test: migrate to build.gradle.kts (flutter/flutte…

be35e10

…r#154125)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

integration_test: migrate to build.gradle.kts #154125

integration_test: migrate to build.gradle.kts #154125

Uh oh!

bartekpacia commented Aug 26, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Aug 26, 2024

Uh oh!

goderbauer commented Sep 10, 2024

Uh oh!

bartekpacia commented Sep 10, 2024

Uh oh!

reidbaker commented Oct 1, 2024

Uh oh!

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

reidbaker commented Oct 2, 2024

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

reidbaker commented Oct 2, 2024

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

Uh oh!

integration_test: migrate to build.gradle.kts #154125

integration_test: migrate to build.gradle.kts #154125

Uh oh!

Conversation

bartekpacia commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 26, 2024

Uh oh!

goderbauer commented Sep 10, 2024

Uh oh!

bartekpacia commented Sep 10, 2024

Uh oh!

reidbaker commented Oct 1, 2024

Uh oh!

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

reidbaker commented Oct 2, 2024

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

reidbaker commented Oct 2, 2024

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

bartekpacia commented Oct 2, 2024

Uh oh!

Uh oh!

bartekpacia commented Aug 26, 2024 •

edited

Loading