upgrade templates to use gradle dsl in android apps #154070
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| @override | ||
| Future<List<String>> getBuildVariants({required FlutterProject project}) async => const <String>[]; | ||
| Future<List<String>> getBuildVariants( | ||
| {required FlutterProject project}) async => | ||
| const <String>[]; | ||
|
|
||
| @override | ||
| Future<String> outputsAppLinkSettings( | ||
| String buildVariant, { | ||
| required FlutterProject project, | ||
| }) async => '/'; | ||
| }) async => | ||
| '/'; |
There was a problem hiding this comment.
These auto-formatter changes are unfortunately a readability downgrade from the original. We could either revert or replace with something better:
@override
Future<List<String>> getBuildVariants({required FlutterProject project}) {
return Future.value(const <String>[]);
}
@override
Future<String> outputsAppLinkSettings(
String buildVariant, {
required FlutterProject project,
}) {
return Future.value('/');
}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
i'm getting Missing type annotation. now ?
i've changed it to this :
return Future<List<String>>.value(const <String>[]);
return Future<String>.value('/');There was a problem hiding this comment.
@nate-thegrate what do u think ?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@bartekpacia i guess this could help for now , not sure about the other tests tho |
|
I don't understand why you're duplicating the same work I'm doing in #154061
help with what? |
|
I hadn't noticed till now, but based on the Setting the target branch as
I'm going to close this one. In the future, my recommendation would be to avoid work that overlaps with another person's contribution—I've learned the hard way that even with good intentions, things can still break. |
towards #151166
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.