-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Fix broken text field with set hint and min and max lines(#153183) #153235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ce9530b
Fix broken text field with set hint and min and max lines(#153183)
zeqinjie a260c80
update variable name
zeqinjie c2eba8f
update test
zeqinjie 85142d4
update description
zeqinjie e7510e8
update
zeqinjie b8b2e32
update
zeqinjie 4b758d2
Merge branch 'master' into fix_153183
zeqinjie 65e5e6f
update curve
zeqinjie 4b66cc5
update size
zeqinjie 7e13d06
update maintainHintHeight and defaults to true
zeqinjie aa4c25e
update des
zeqinjie 5380404
update
zeqinjie d5f0fe1
update test
zeqinjie cf3975b
update test name
zeqinjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animation logic seems complicated. I don't know what the expectation is here, but we probably want to test any non-trivial behavior. (Consider
AnimationSheetBuilder
)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkwingsmt Sorry, I don't know much about the AnimationSheetBuilder component, so I refer to
testWidgets('InputDecoration.collapsed accepts hintFadeDuration')
to write tests