[flutter_tools] Include more details in structured errors sent to a DAP client #150698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AP client The debug adapter converts Flutter's structured errors into a text format to be sent to the debug client and shown in the console. When an error is not the first error since the last reload, it is shown as just a summary (since it may be caused by a prior error). In this mode, the filter was causing some important information (the erroring widget) to be omitted. This tweaks the logic to include child nodes of a DiagnosticBlock in this mode. Fixes Dart-Code/Dart-Code#4743
andrewkolos
approved these changes
Jun 26, 2024
packages/flutter_tools/lib/src/debug_adapters/error_formatter.dart
Outdated
Show resolved
Hide resolved
|
auto label is removed for flutter/flutter/150698, due to - The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 29, 2024
Manual roll requested by dit@google.com flutter/flutter@15f95ce...651a17d 2024-06-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from a78f5ce743ce to 2f7e9ab27493 (11 revisions) (flutter/flutter#151002) 2024-06-28 hi@timcreated.it Draggable feedback positioning (flutter/flutter#149040) 2024-06-28 dr@schlau.bi Add support for type-safe plugin apply (flutter/flutter#150958) 2024-06-28 dev@alestiago.com Use caret syntax with flutter create command (flutter/flutter#150920) 2024-06-28 engine-flutter-autoroll@skia.org Roll Packages from 03f5f6d to 412ec46 (12 revisions) (flutter/flutter#150985) 2024-06-28 danny@tuppeny.com [flutter_tools] Include more details in structured errors sent to a DAP client (flutter/flutter#150698) 2024-06-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 94591ffb20df to a78f5ce743ce (1 revision) (flutter/flutter#150972) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…AP client (flutter#150698) The debug adapter converts Flutter's structured errors into a text format to be sent to the debug client and shown in the console. When an error is not the first error since the last reload, it is shown as just a summary (since it may be caused by a prior error). In this mode, the filter was causing some important information (the erroring widget) to be omitted. This tweaks the logic to include child nodes of a `DiagnosticBlock` in this mode. Fixes Dart-Code/Dart-Code#4743 ## Before:  ## After: 
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug adapter converts Flutter's structured errors into a text format to be sent to the debug client and shown in the console. When an error is not the first error since the last reload, it is shown as just a summary (since it may be caused by a prior error). In this mode, the filter was causing some important information (the erroring widget) to be omitted.
This tweaks the logic to include child nodes of a
DiagnosticBlockin this mode.Fixes Dart-Code/Dart-Code#4743
Before:
After:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.