Add tests for form_text_field.1.dart #150481

ValentinVignal · 2024-06-19T08:10:18Z

Contributes to #130459

It adds a test for

examples/api/lib/material/text_form_field/text_form_field.1.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ValentinVignal · 2024-06-19T08:10:38Z

examples/api/test/material/text_form_field/text_form_field.1_test.dart

+    List<bool> getFocuses() {
+      return editableText.evaluate()
+        .map((Element finderResult) => (finderResult.widget as EditableText).focusNode.hasFocus)
+        .toList();
+    }


Do you have a better way to get the focuses?

Nothing simpler in mind, I think this utility function is readable as-is 👍

…-field-1

bleroux

LGTM!

bleroux · 2024-06-21T08:36:40Z

examples/api/test/material/text_form_field/text_form_field.1_test.dart

+    List<bool> getFocuses() {
+      return editableText.evaluate()
+        .map((Element finderResult) => (finderResult.widget as EditableText).focusNode.hasFocus)
+        .toList();
+    }


Nothing simpler in mind, I think this utility function is readable as-is 👍

bleroux · 2024-06-21T08:37:03Z

examples/api/test/material/text_form_field/text_form_field.1_test.dart

+
+    expect(getFocuses(), const <bool>[true, false, false, false, false]);
+  });
+


Consider removing this extra line

…-field-1

auto-submit · 2024-06-24T12:30:20Z

A reason for requesting a revert of flutter/flutter/150481 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

cbracken · 2024-06-24T12:31:25Z

Reason for revert: Surprisingly, the following test seems to be consistently failing on Windows after the addition of this test:

flutter/packages/flutter/test/widgets/sliver_tree_test.dart: .toggleNodeWith, onNodeToggle

This reverts commit 27b9616.

Reverts: #150481 Initiated by: cbracken Reason for reverting: Surprisingly, the following test seems to be consistently failing on Windows after the addition of this test: ``` flutter/packages/flutter/test/widgets/sliver_tree_test.dart: .toggleNodeWith, onNodeToggle ``` Original PR Author: ValentinVignal Reviewed By: {TahaTesser, bleroux} This change reverts the following previous change: Contributes to #130459 It adds a test for - `examples/api/lib/material/text_form_field/text_form_field.1.dart`

cbracken · 2024-06-24T12:51:11Z

Reverted this since the above-mentioned test was failing consistently starting at this patch. The main possibility I was envisioning was some sort of non-hermetic crossover between the tests, but even after the revert, the above-mentioned test is consistently failing. It seems there's some other non-hermetic component of our tests.

@ValentinVignal apologies for the noise here. Please re-send out this patch and we'll get it re-landed.

…r#150696)" This reverts commit 70e9b41.

ValentinVignal · 2024-06-25T02:38:29Z

Sure @cbracken , no problem, I re-created the PR here: #150750

) This reverts commit 70e9b41. Relands #150481 Contributes to #130459 It adds a test for - `examples/api/lib/material/text_form_field/text_form_field.1.dart`

Roll Flutter from 6c06abb to e726eb4 (51 revisions) flutter/flutter@6c06abb...e726eb4 2024-06-25 engine-flutter-autoroll@skia.org Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter/flutter#150779) 2024-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from afa7ce19bca8 to fbd92055f3a6 (1 revision) (flutter/flutter#150777) 2024-06-25 32538273+ValentinVignal@users.noreply.github.com Reland Add tests for form_text_field.1.dart (#150481) (#150696) (flutter/flutter#150750) 2024-06-25 104349824+huycozy@users.noreply.github.com Add an example for CupertinoPopupSurface (flutter/flutter#150357) 2024-06-25 danny@tuppeny.com [flutter_tools/dap] Handle app.stop errors when launching/attaching (flutter/flutter#149734) 2024-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from be7db94196fe to afa7ce19bca8 (18 revisions) (flutter/flutter#150762) 2024-06-25 sigurdm@google.com Remove dubious comment (flutter/flutter#150608) 2024-06-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual engine roll to 6884e83 (#150733)" (flutter/flutter#150746) 2024-06-25 34871572+gmackall@users.noreply.github.com Manual engine roll to 6884e83 (flutter/flutter#150733) 2024-06-24 goderbauer@google.com Linkify 'see also' sections (flutter/flutter#150734) 2024-06-24 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#150712) 2024-06-24 parlough@gmail.com Update flutter.dev links from framework to more permanent destinations (flutter/flutter#150531) 2024-06-24 jason-simmons@users.noreply.github.com Manual engine roll to be7db94196fe (flutter/flutter#150714) 2024-06-24 reidbaker@google.com allow adb to set canfail then use canFail=true for clearing logs (flutter/flutter#150517) 2024-06-24 reidbaker@google.com Update android_device.dart to have clearLogs not print to standard error (flutter/flutter#150197) 2024-06-24 goderbauer@google.com Update issue link in analysis_options.yaml (flutter/flutter#150395) 2024-06-24 srawlins@google.com Fix a number of broken doc comment references (flutter/flutter#150540) 2024-06-24 katelovett@google.com Fix flaky sliver tree test (flutter/flutter#150707) 2024-06-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add tests for form_text_field.1.dart (#150481)" (flutter/flutter#150696) 2024-06-24 32538273+ValentinVignal@users.noreply.github.com Add tests for form_text_field.1.dart (flutter/flutter#150481) 2024-06-22 matthew-carroll@users.noreply.github.com Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves #148291) (flutter/flutter#150661) 2024-06-22 dkwingsmt@users.noreply.github.com [CupertinoActionSheet] Fix the layout (part 1) (flutter/flutter#149636) 2024-06-21 34871572+gmackall@users.noreply.github.com Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter/flutter#150585) 2024-06-21 jhy03261997@gmail.com [a11y] Update semantics in bottom_navigation_bar.dart (flutter/flutter#150576) 2024-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (flutter/flutter#150637) 2024-06-21 dkwingsmt@users.noreply.github.com Reland 4: [CupertinoActionSheet] Match colors to native (flutter/flutter#150442) 2024-06-21 rmolivares@renzo-olivares.dev Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter/flutter#149295) 2024-06-21 limanegaya@gmail.com made SelectionArea alignment consistent between web and other platform (flutter/flutter#150037) 2024-06-21 moritz@suemmermann.de Fix link hook typo (flutter/flutter#150194) 2024-06-21 sigurdm@google.com Stop looking for .packages when analyzing (flutter/flutter#150349) 2024-06-20 parlough@gmail.com Update flutter.dev links from misc packages to more permanent destinations (flutter/flutter#150532) 2024-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (flutter/flutter#150582) 2024-06-20 36861262+QuncCccccc@users.noreply.github.com Update Material token to the latest 4.1.0 (flutter/flutter#150382) 2024-06-20 34871572+gmackall@users.noreply.github.com Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter/flutter#150471) 2024-06-20 bruno.leroux@gmail.com Make popup menu hardcoded padding configurable (flutter/flutter#150506) 2024-06-20 christopherfujino@gmail.com [flutter_tools] un-hide the --dds flag (flutter/flutter#150280) 2024-06-20 59215665+davidhicks980@users.noreply.github.com [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter/flutter#149586) 2024-06-20 32538273+ValentinVignal@users.noreply.github.com Add test for inherited_notifier.0.dart (flutter/flutter#150344) 2024-06-20 andrewrkolos@gmail.com [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter/flutter#150461) 2024-06-20 82763757+NobodyForNothing@users.noreply.github.com Test InputDecoration API examples (flutter/flutter#148560) 2024-06-20 polinach@google.com Clean leaky tests. (flutter/flutter#150335) 2024-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9c497f178d3 to dd37cefd4a94 (2 revisions) (flutter/flutter#150537) 2024-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a31279381b40 to f9c497f178d3 (9 revisions) (flutter/flutter#150528) 2024-06-19 32538273+ValentinVignal@users.noreply.github.com Add tests for about_list_tile.0.dart (flutter/flutter#150181) 2024-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ad18fe4c0b5 to a31279381b40 (7 revisions) (flutter/flutter#150473) 2024-06-18 jhy03261997@gmail.com Revert "[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items" (flutter/flutter#150445) ...

* master: (23 commits) Roll pub packages (flutter#150810) Remove reference to `MaterialApp` and `showCupertinoModalPopup` from `CupertinoAlertDialog` (flutter#150725) Read `AndroidManifest.xml` and emit `manifest-impeller-(enabled|disabled)` analytics (flutter#150791) [flutter_tools] Shut down Chromium cleanly using a command sent through the debug protocol (flutter#150645) Reland fix inputDecorator hint color on M3 (flutter#150278) Roll Flutter Engine from 62e0b5f9c340 to 94023d711db3 (7 revisions) (flutter#150797) Fix collapsed InputDecorator minimum height (flutter#150770) Add more warm up frame docs (flutter#150464) Roll pub packages (flutter#150739) Add `focusNode`, `focusColor`, `onFocusChange`, `autofocus` to `CupertinoButton` (flutter#150721) Document RenderObject._relayoutBoundary and its invariant; small refactors (flutter#150527) Roll Flutter Engine from 6313b1e5afd7 to 62e0b5f9c340 (1 revision) (flutter#150790) fix a typo (flutter#150682) Fix link in RenderObjectWidget doc comment (flutter#150600) Roll Flutter Engine from fbd92055f3a6 to 6313b1e5afd7 (1 revision) (flutter#150781) [tool] make `ErrorHandlingFileSystem.deleteIfExists` catch error code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter#150741) Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter#150779) Roll Flutter Engine from afa7ce19bca8 to fbd92055f3a6 (1 revision) (flutter#150777) Reland Add tests for form_text_field.1.dart (flutter#150481) (flutter#150696) (flutter#150750) Add an example for CupertinoPopupSurface (flutter#150357) ...

cbracken · 2024-06-26T03:31:30Z

Thank @ValentinVignal and apologies again for the churn!

Contributes to flutter#130459 It adds a test for - `examples/api/lib/material/text_form_field/text_form_field.1.dart`

…ter#150696) Reverts: flutter#150481 Initiated by: cbracken Reason for reverting: Surprisingly, the following test seems to be consistently failing on Windows after the addition of this test: ``` flutter/packages/flutter/test/widgets/sliver_tree_test.dart: .toggleNodeWith, onNodeToggle ``` Original PR Author: ValentinVignal Reviewed By: {TahaTesser, bleroux} This change reverts the following previous change: Contributes to flutter#130459 It adds a test for - `examples/api/lib/material/text_form_field/text_form_field.1.dart`

test: Add tests for form_text_field.1.dart

c837dc2

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 19, 2024

ValentinVignal commented Jun 19, 2024

View reviewed changes

justinmc requested review from bleroux and TahaTesser June 20, 2024 21:45

Merge branch 'master' into flutter/api/example/add-test-for-text-form…

47e81b6

…-field-1

bleroux approved these changes Jun 21, 2024

View reviewed changes

ValentinVignal and others added 2 commits June 21, 2024 18:03

refactor: Remove extra empty line

9f383fc

Merge branch 'master' into flutter/api/example/add-test-for-text-form…

89d59f9

…-field-1

TahaTesser approved these changes Jun 23, 2024

View reviewed changes

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2024

auto-submit bot merged commit 27b9616 into flutter:master Jun 24, 2024
137 checks passed

cbracken added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 24, 2024

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 24, 2024

cbracken added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 24, 2024

auto-submit bot pushed a commit that referenced this pull request Jun 24, 2024

Revert "Add tests for form_text_field.1.dart (#150481)"

f9213d1

This reverts commit 27b9616.

auto-submit bot mentioned this pull request Jun 24, 2024

Reverts "Add tests for form_text_field.1.dart (#150481)" #150696

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 24, 2024

engine-flutter-autoroll mentioned this pull request Jun 24, 2024

Roll Flutter from 6c06abbb5576 to 70e9b4185e3d (33 revisions) flutter/packages#6977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2024

27b9616 Add tests for form_text_field.1.dart (flutter/flutter#150481)

bd64841

engine-flutter-autoroll mentioned this pull request Jun 24, 2024

Roll Flutter from 6c06abbb5576 to 70e9b4185e3d (33 revisions) flutter/packages#6978

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2024

27b9616 Add tests for form_text_field.1.dart (flutter/flutter#150481)

44a9945

ValentinVignal added a commit to ValentinVignal/flutter that referenced this pull request Jun 25, 2024

Reland Add tests for form_text_field.1.dart (flutter#150481)" (flutte…

30658f3

…r#150696)" This reverts commit 70e9b41.

ValentinVignal mentioned this pull request Jun 25, 2024

Reland Add tests for form_text_field.1.dart (#150481) (#150696) #150750

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to 93c14565f0ec (49 revisions) flutter/packages#6985

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

27b9616 Add tests for form_text_field.1.dart (flutter/flutter#150481)

12c77b8

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to f90f40a86619 (50 revisions) flutter/packages#6986

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

27b9616 Add tests for form_text_field.1.dart (flutter/flutter#150481)

0d4ac34

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to e726eb401c2c (51 revisions) flutter/packages#6987

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

27b9616 Add tests for form_text_field.1.dart (flutter/flutter#150481)

a2d996f

sigurdm pushed a commit to sigurdm/flutter that referenced this pull request Jun 26, 2024

Add tests for form_text_field.1.dart (flutter#150481)

a917f51

Contributes to flutter#130459 It adds a test for - `examples/api/lib/material/text_form_field/text_form_field.1.dart`

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

27b9616 Add tests for form_text_field.1.dart (flutter/flutter#150481)

9bfcc34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add tests for form_text_field.1.dart #150481

Add tests for form_text_field.1.dart #150481

Uh oh!

ValentinVignal commented Jun 19, 2024

Uh oh!

ValentinVignal Jun 19, 2024

Uh oh!

bleroux Jun 21, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux Jun 21, 2024

Uh oh!

bleroux Jun 21, 2024

Uh oh!

Uh oh!

auto-submit bot commented Jun 24, 2024

Uh oh!

cbracken commented Jun 24, 2024

Uh oh!

cbracken commented Jun 24, 2024

Uh oh!

ValentinVignal commented Jun 25, 2024

Uh oh!

cbracken commented Jun 26, 2024

Uh oh!

Uh oh!


		expect(getFocuses(), const <bool>[true, false, false, false, false]);
		});

Add tests for form_text_field.1.dart #150481

Add tests for form_text_field.1.dart #150481

Uh oh!

Conversation

ValentinVignal commented Jun 19, 2024

Pre-launch Checklist

Uh oh!

ValentinVignal Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Jun 24, 2024

Uh oh!

cbracken commented Jun 24, 2024

Uh oh!

cbracken commented Jun 24, 2024

Uh oh!

ValentinVignal commented Jun 25, 2024

Uh oh!

cbracken commented Jun 26, 2024

Uh oh!

Uh oh!