这是indexloc提供的服务，不要输入任何密码
Skip to content

Change android_plugin_new_output_dir_test.dart test description #149198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

Change android_plugin_new_output_dir_test.dart test description #149198

merged 2 commits into from
May 28, 2024

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented May 28, 2024 •
edited
Loading

Changes the test description to what I understand it is testing.

Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157.

cc @chunfengyao as the original author, as I see you are still active on Github 🙂

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 28, 2024
@gmackall gmackall marked this pull request as ready for review May 28, 2024 18:52
@gmackall gmackall requested a review from a team May 28, 2024 18:53
@loic-sharma loic-sharma added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels May 28, 2024
@loic-sharma
Copy link
Member

Landing this on red to force retry a postsubmit test that I don't have permissions to retry manually. See https://discord.com/channels/608014603317936148/1245129481124053164/1245149408916672592 for context.

@auto-submit auto-submit bot merged commit df64ca0 into flutter:master May 28, 2024
@christopherfujino christopherfujino mentioned this pull request May 28, 2024
Open
@chunfengyao
Copy link
Contributor

If someone modifies the output back to '${HOME}/.pub/hosted/${plugin_name}/build/.' in a new pull request, they will see the message 'Plugins should use individualized build directories based on their name.' as an error. will It confuse the author, should the message be 'Plugins should use individualized build directories based on their name.',or this one:'Error: Plugins are now required to use individualized build directories. Please pay attention to it.'?

the test()function will print the message when test failed. probably, the mesage should show why test is failed for users.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024
@engine-flutter-autoroll
df64ca0 Change android_plugin_new_output_dir_test.dart test descrip…
7835677 
…tion (flutter/flutter#149198)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024
@engine-flutter-autoroll
df64ca0 Change android_plugin_new_output_dir_test.dart test descrip…
1de792e 
…tion (flutter/flutter#149198)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 29, 2024
@engine-flutter-autoroll
Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (#6829)
82a811f 
flutter/flutter@a1a33e6...c85fa6a

2024-05-29 polinach@google.com Clean leak in editable_text_test.dart. (flutter/flutter#149223)
2024-05-29 sokolovskyi.konstantin@gmail.com Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180)
2024-05-29 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220)
2024-05-29 hany212mohamed@gmail.com Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568)
2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224)
2024-05-29 yinxulolol@gmail.com sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470)
2024-05-29 luis901101@gmail.com Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767)
2024-05-28 737941+loic-sharma@users.noreply.github.com Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207)
2024-05-28 polinach@google.com Remove opt out for CurvedAnimation. (flutter/flutter#147594)
2024-05-28 31859944+LongCatIsLooong@users.noreply.github.com Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062)
2024-05-28 polinach@google.com Clean leaky test. (flutter/flutter#149199)
2024-05-28 34871572+gmackall@users.noreply.github.com Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198)
2024-05-28 leroux_bruno@yahoo.fr fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161)
2024-05-28 77919688+varunkamanibosc@users.noreply.github.com Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer� (flutter/flutter#143079)
2024-05-28 jmccandless@google.com Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006)
2024-05-28 31859944+LongCatIsLooong@users.noreply.github.com Remove `TextEditingController` private member access (flutter/flutter#149042)
2024-05-28 engine-flutter-autoroll@skia.org Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184)
2024-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169)
2024-05-28 kevmoo@users.noreply.github.com [tool] Use kebabCase directly (flutter/flutter#149150)
2024-05-28 katelovett@google.com [wiki migration] Leftover wiki pages and links (flutter/flutter#148989)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gmackall
Copy link
Member Author

gmackall commented May 29, 2024 •
edited
Loading

If someone modifies the output back to '${HOME}/.pub/hosted/${plugin_name}/build/.' in a new pull request, they will see the message 'Plugins should use individualized build directories based on their name.' as an error. will It confuse the author, should the message be 'Plugins should use individualized build directories based on their name.',or this one:'Error: Plugins are now required to use individualized build directories. Please pay attention to it.'?

the test()function will print the message when test failed. probably, the mesage should show why test is failed for users.

The names of tests in this repository are generally given based on what the test tests, not based on an error message that should be thrown when the test fails, so I don't think this will be confusing - it is implicit that the error is that the behavior expected in the title of the test is not currently happening, because the test is failing.

e.g. passing one file works, build succeeds with api 33 features

victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@gmackall @victorsanni
Change android_plugin_new_output_dir_test.dart test description (fl…
6b47ba1 
…utter#149198)

Changes the test description to what I understand it is testing. 

Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157.

cc @chunfengyao as the original author, as I see you are still active on Github �
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
df64ca0 Change android_plugin_new_output_dir_test.dart test descrip…
d4f4aaf 
…tion (flutter/flutter#149198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmackall @loic-sharma @chunfengyao @reidbaker @yaakovschectman