Reland "Update FocusManager platform check to include iOS"
#148984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
I think |
|
@Renzo-Olivares I hadn't noticed that the |
| TargetPlatform.fuchsia || TargetPlatform.linux => true, | ||
| TargetPlatform.windows || TargetPlatform.macOS => true, | ||
| }; | ||
| if (kIsWeb || mobileDevice) { |
There was a problem hiding this comment.
What do you think about removing this check, and instead specifying Android and iOS as the test variants, and skipping the web test? I think as the test stands now it is only running on Android.
There was a problem hiding this comment.
Can't believe I didn't notice that you can specify a test variant! Thanks for the suggestion.
5333586 to
99010c9
Compare
Renzo-Olivares
approved these changes
May 23, 2024
| expect(focusNode.hasPrimaryFocus, isTrue); | ||
| }, | ||
| skip: kIsWeb, // [intended] | ||
| variant: TargetPlatformVariant.only(TargetPlatform.iOS, TargetPlatform.android), |
There was a problem hiding this comment.
I think this should be
variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.android, TargetPlatform.iOS }).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 24, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 24, 2024
flutter/flutter@8d955cd...8dd0831 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6041cd9049c to 4ab442475223 (1 revision) (flutter/flutter#149039) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d896f4feb76 to c6041cd9049c (1 revision) (flutter/flutter#149035) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fe3b26294d8f to 8d896f4feb76 (1 revision) (flutter/flutter#149030) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4fb08f21757 to fe3b26294d8f (1 revision) (flutter/flutter#149028) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from f873230ce823 to b4fb08f21757 (2 revisions) (flutter/flutter#149025) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d78f66753332 to f873230ce823 (1 revision) (flutter/flutter#149021) 2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 768c90ee5dc7 to d78f66753332 (3 revisions) (flutter/flutter#149011) 2024-05-23 nate.w5687@gmail.com Reland "Update `FocusManager` platform check to include iOS" (flutter/flutter#148984) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from ad12c5d02a8c to 768c90ee5dc7 (2 revisions) (flutter/flutter#149003) 2024-05-23 tessertaha@gmail.com Fix `SnackBar` action text button overlay color (flutter/flutter#148961) 2024-05-23 42757204+wyqlxf@users.noreply.github.com Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148930) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a48302f6f4e to ad12c5d02a8c (3 revisions) (flutter/flutter#148993) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 964f087f288c to 2a48302f6f4e (1 revision) (flutter/flutter#148950) 2024-05-23 katelovett@google.com [wiki migration] Remaining pages under docs/contributing/ (flutter/flutter#148790) 2024-05-23 katelovett@google.com [wiki migration] Web team pages (flutter/flutter#148777) 2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test remaining transitions api examples (flutter/flutter#148302) 2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test snack bar examples (flutter/flutter#147774) 2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Add tests for material banner example (flutter/flutter#147733) 2024-05-23 engine-flutter-autoroll@skia.org Roll Packages from 6525441 to 1008d9e (6 revisions) (flutter/flutter#148980) 2024-05-23 goderbauer@google.com Revert "const vs. non-const widget build benchmark" (flutter/flutter#148970) 2024-05-23 ian@hixie.ch Remove hidden dependencies on HttpClient (flutter/flutter#148773) 2024-05-23 rmolivares@renzo-olivares.dev Revert "Update `FocusManager` platform check to include iOS" (flutter/flutter#148978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…#148984) It looks like removing `kIsWeb` from the `FocusManager._appLifecycleListener` platform check is causing [memory leaks](flutter#148985) and test failures. This pull request fixes flutter#148475 and prevents the test failures shown in flutter#148978.
|
Failed to create CP due to merge conflicts. |
|
When will this land in stable? It has been baking in master for over a month now. |
|
Hi @techouse, I appreciate your concern! Unfortunately, a comment like this one contravenes our issue hygiene guidelines. But to answer your question: it will land in stable once someone makes a cherry-pick pull request, and that PR is approved. I was planning to manually create a PR within the next day or two! |
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR ended up having incompatible changes with #148067.