这是indexloc提供的服务，不要输入任何密码
Skip to content

Properly guard context access in then clauses #147935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

Properly guard context access in then clauses #147935

merged 1 commit into from
May 7, 2024

Conversation

goderbauer
Copy link
Member

Prepares for a fix to the use_build_context_synchronously lint (https://dart-review.googlesource.com/c/sdk/+/365541) that will complain about these unsafe usages.

@goderbauer goderbauer requested a review from srawlins May 7, 2024 17:44
@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label May 7, 2024
@goderbauer goderbauer requested a review from gspencergoog May 7, 2024 17:54
gspencergoog
gspencergoog approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2024
@auto-submit auto-submit bot merged commit 8796562 into flutter:master May 7, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
8796562 Properly guard context access in then clauses (flutter/flutte…
fbbaf38 
…r#147935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
8796562 Properly guard context access in then clauses (flutter/flutte…
2999bab 
…r#147935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
8796562 Properly guard context access in then clauses (flutter/flutte…
ed4ffb6 
…r#147935)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
8796562 Properly guard context access in then clauses (flutter/flutte…
3b84dd0 
…r#147935)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
8796562 Properly guard context access in then clauses (flutter/flutte…
c4d7421 
…r#147935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goderbauer @srawlins @gspencergoog