这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove a bad assert from tooltip implementation #127629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2023
Merged

Remove a bad assert from tooltip implementation #127629

merged 2 commits into from
May 26, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented May 25, 2023 •
edited
Loading

Fixes #127575

The _handleMouseEnter and _handleMouseExit calls are balanced, but the tooltip could be dismissed by an external PointerDown event interacting with a different UI component so the assert(_activeHoveringPointerDevices.isNotEmpty); does not really make sense.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2023
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 25, 2023
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 26, 2023
gspencergoog
gspencergoog approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label May 26, 2023
@auto-submit auto-submit bot merged commit 56808b4 into flutter:master May 26, 2023
@LongCatIsLooong LongCatIsLooong deleted the remove-tooltip-bad-assert branch May 26, 2023 00:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
56808b4 Remove a bad assert from tooltip implementation (flutter/flut…
dc9354e 
…ter#127629)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
56808b4 Remove a bad assert from tooltip implementation (flutter/flut…
da2a1a6 
…ter#127629)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
Roll Flutter from 216605b to ee162e4 (53 revisions) (#4090)
0906c5f 
Roll Flutter from 216605b to ee162e4 (53 revisions)

flutter/flutter@216605b...ee162e4

2023-05-26 engine-flutter-autoroll@skia.org Roll Packages from 995bfc5 to 9f8dcc5 (4 revisions) (flutter/flutter#127671)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 474fcbbe445e to 8573f3b63a1f (1 revision) (flutter/flutter#127647)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f63fcf5a274e to 474fcbbe445e (1 revision) (flutter/flutter#127644)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6fcbe31ba1a to f63fcf5a274e (1 revision) (flutter/flutter#127642)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from bec5da5bff7c to b6fcbe31ba1a (1 revision) (flutter/flutter#127641)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 593d4d6b1f9b to bec5da5bff7c (2 revisions) (flutter/flutter#127638)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f4dc96aef71b to 593d4d6b1f9b (1 revision) (flutter/flutter#127635)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff04d2fdd12b to f4dc96aef71b (2 revisions) (flutter/flutter#127633)
2023-05-26 31859944+LongCatIsLooong@users.noreply.github.com Remove a bad assert from tooltip implementation (flutter/flutter#127629)
2023-05-26 31859944+LongCatIsLooong@users.noreply.github.com Remove rounding from TextPainter (flutter/flutter#127099)
2023-05-26 109253501+pdblasi-google@users.noreply.github.com Adds `TestDisplay` API for testing `Display` features (flutter/flutter#127525)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a4e675ab0b4 to ff04d2fdd12b (3 revisions) (flutter/flutter#127630)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 99f2653cbb79 to 6a4e675ab0b4 (2 revisions) (flutter/flutter#127625)
2023-05-25 54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/flutter#127537)
2023-05-25 chillers@google.com Indent markdown value on CP issue template (flutter/flutter#127623)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6ff02c17268f to 99f2653cbb79 (6 revisions) (flutter/flutter#127619)
2023-05-25 42216813+eliasyishak@users.noreply.github.com `ProcessResultMatcher` created and used in test (flutter/flutter#127414)
2023-05-25 chillers@google.com Fix yaml lint issue (flutter/flutter#127600)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 515a4bfc4b6e to 6ff02c17268f (1 revision) (flutter/flutter#127609)
2023-05-25 36861262+QuncCccccc@users.noreply.github.com `SearchBar` should not be impacted by overall `InputDecorationTheme` (flutter/flutter#127465)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) (flutter/flutter#127601)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) (flutter/flutter#127591)
2023-05-25 dnfield@google.com avoid incorrect usage of TimelineTask (flutter/flutter#127527)
2023-05-25 tessertaha@gmail.com Add `ScrollNotificationObserver` sample (flutter/flutter#127023)
2023-05-25 engine-flutter-autoroll@skia.org Roll Packages from fba97fa to 995bfc5 (3 revisions) (flutter/flutter#127590)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) (flutter/flutter#127577)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) (flutter/flutter#127565)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) (flutter/flutter#127563)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) (flutter/flutter#127560)
2023-05-25 31859944+LongCatIsLooong@users.noreply.github.com Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation (flutter/flutter#119199)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) (flutter/flutter#127554)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) (flutter/flutter#127551)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) (flutter/flutter#127546)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) (flutter/flutter#127544)
2023-05-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) (flutter/flutter#127542)
2023-05-24 chillers@google.com Revert "Update labeler action wildcards" (flutter/flutter#127541)
2023-05-24 mdebbar@google.com [web] ui.platformViewRegistry => ui_web.platformViewRegistry (flutter/flutter#127493)
2023-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) (flutter/flutter#127536)
2023-05-24 lsaudon@gmail.com Add missing parameters in `TextFormField` (flutter/flutter#127020)
2023-05-24 chillers@google.com Update labeler action wildcards (flutter/flutter#127524)
2023-05-24 31859944+LongCatIsLooong@users.noreply.github.com Improve `TextPainter.layout` caching (flutter/flutter#118128)
2023-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (flutter/flutter#127533)
2023-05-24 leroux_bruno@yahoo.fr Fix ScrollPosition overscroll precision error (flutter/flutter#127321)
2023-05-24 dleyba042@gmail.com `Slider.onChangeStart` & `Slider.onChangeEnd` are not called on keyboard shortcuts (flutter/flutter#126896)
2023-05-24 bdero@google.com Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (flutter/flutter#127514)
2023-05-24 chillers@google.com Update CP template to include timeline and changelog (flutter/flutter#127507)
...
@reidbaker reidbaker mentioned this pull request May 26, 2023
Merged
8 tasks
@HansMuller HansMuller mentioned this pull request May 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
56808b4 Remove a bad assert from tooltip implementation (flutter/flut…
937e732 
…ter#127629)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
56808b4 Remove a bad assert from tooltip implementation (flutter/flut…
3305736 
…ter#127629)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
56808b4 Remove a bad assert from tooltip implementation (flutter/flut…
51f0de2 
…ter#127629)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
56808b4 Remove a bad assert from tooltip implementation (flutter/flut…
e6a2d79 
…ter#127629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asserts in widget test with hover
2 participants
@LongCatIsLooong @gspencergoog