这是indexloc提供的服务，不要输入任何密码
Skip to content

[CP] Integration tests support AGP 8.0 #125686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2023
Merged

[CP] Integration tests support AGP 8.0 #125686

merged 2 commits into from
May 1, 2023

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Apr 28, 2023 •
edited
Loading

Original issue #125181
Cherry pick issue #125688

If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker
Smallest change required to support host apps using agp 8.0 (#125657)
00e6d69 
Testing AGP 8.0 is not possible with the existing infra because of the java version on CI machines. See #125325 for more details.

#125181
@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 28, 2023
@reidbaker reidbaker mentioned this pull request Apr 28, 2023
Closed
@reidbaker reidbaker changed the base branch from master to flutter-3.10-candidate.1 April 28, 2023 15:14
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

christopherfujino
christopherfujino approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker reidbaker requested a review from itsjustkevin May 1, 2023 18:15
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2023
@itsjustkevin itsjustkevin merged commit c4e1925 into flutter-3.10-candidate.1 May 1, 2023
@itsjustkevin itsjustkevin deleted the gradle-8-0-cp-into-3-10 branch May 1, 2023 20:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c4e19250e [CP] Integration tests support AGP 8.0 (flutter/flutter#125686
33dc0d5 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c4e19250e [CP] Integration tests support AGP 8.0 (flutter/flutter#125686
a248938 
)
@reidbaker reidbaker mentioned this pull request May 31, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine repository. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidbaker @christopherfujino @itsjustkevin