Allow users to provide route settings to showMenu
#124935
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@fzyzcjy Thanks for the PR! This looks like an interesting change, but as the bot says above, it will need some tests. Once it has tests, we can take a closer look at it. |
|
Sure! I will add tests later when having time and ping |
|
@fzyzcjy Just confirm that you're done with this, and I'll submit it. Thanks for the PR! |
|
@gspencergoog Yes I am done. Thanks! |
|
Actually, we need a second reviewer (should be quick). |
|
LGTM |
Background: I am adding logging to things like dialogs, bottom sheets and menus. Then I realized that, showMenu does not allow users to provide RouteSettings, while showDialog and showModalBottomSheet both allow. Therefore, IMHO a consistent API design may need to add this to showMenu.
I will add tests if this proposal looks OK :)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.