这是indexloc提供的服务,不要输入任何密码
Skip to content

flutter-tool, web: update HTML template serviceWorkerVersion to be const #124826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 13, 2023

Fixes #124783

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 13, 2023
@kevmoo kevmoo requested a review from mdebbar April 13, 2023 23:46
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 14, 2023

auto label is removed for flutter/flutter, pr: 124826, due to - The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2023
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2023
@auto-submit auto-submit bot merged commit 3bc07c1 into master Apr 14, 2023
@auto-submit auto-submit bot deleted the i124783 branch April 14, 2023 02:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 14, 2023
flutter/flutter@be45eb2...f740544

2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from b7b2e7b742aa to 4b96e38c9275 (1 revision) (flutter/flutter#124856)
2023-04-14 6655696+guidezpl@users.noreply.github.com Adjust repo config for VS Code formatting (flutter/flutter#122758)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f86a05ac932 to b7b2e7b742aa (4 revisions) (flutter/flutter#124845)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00bef00f64a7 to 4f86a05ac932 (5 revisions) (flutter/flutter#124841)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from ad222b0c93b9 to 00bef00f64a7 (1 revision) (flutter/flutter#124837)
2023-04-14 andrewrkolos@gmail.com [flutter_tools] Reorganize android_studio_test.dart (flutter/flutter#124834)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from ce7be0093399 to ad222b0c93b9 (1 revision) (flutter/flutter#124832)
2023-04-14 magder@google.com Remove Finder extended attributes in build target before code signing iOS frameworks (flutter/flutter#123896)
2023-04-14 kevmoo@users.noreply.github.com flutter-tool, web: update HTML template serviceWorkerVersion to be const (flutter/flutter#124826)
2023-04-14 tessertaha@gmail.com Fix `CupertinoContextMenu` throws exception on route animation (flutter/flutter#124785)
2023-04-14 kevmoo@users.noreply.github.com flutter-tool: enum cleanup (flutter/flutter#124760)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1289f4b513ef to ce7be0093399 (1 revision) (flutter/flutter#124825)
2023-04-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.1 to 3.5.2 (flutter/flutter#124822)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2ff14d733daa to 1289f4b513ef (2 revisions) (flutter/flutter#124824)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb3e7d52ebbc to 2ff14d733daa (1 revision) (flutter/flutter#124820)
2023-04-13 reidbaker@google.com i123643 print java version gradle (flutter/flutter#123644)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 496543715bdb to eb3e7d52ebbc (3 revisions) (flutter/flutter#124816)
2023-04-13 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#124709)
2023-04-13 21270878+elliette@users.noreply.github.com [flutter_tools] Disable flaky `output_web_test` test case (flutter/flutter#124257)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 26eddb64e8ea to 496543715bdb (1 revision) (flutter/flutter#124812)
2023-04-13 tessertaha@gmail.com Refactor `SliverAppBar.medium` & `SliverAppBar.large` to fix several issues (flutter/flutter#122542)
2023-04-13 jmccandless@google.com Improve the docs around the TextSelectionHandleControls deprecations (flutter/flutter#123827)
2023-04-13 engine-flutter-autoroll@skia.org Roll Packages from fe5615f to d01f4ea (5 revisions) (flutter/flutter#124795)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 81a57d24e62a to 26eddb64e8ea (1 revision) (flutter/flutter#124794)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
…nst (flutter#124826)

flutter-tool, web: update HTML template serviceWorkerVersion to be const
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
flutter/flutter@be45eb2...f740544

2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from b7b2e7b742aa to 4b96e38c9275 (1 revision) (flutter/flutter#124856)
2023-04-14 6655696+guidezpl@users.noreply.github.com Adjust repo config for VS Code formatting (flutter/flutter#122758)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f86a05ac932 to b7b2e7b742aa (4 revisions) (flutter/flutter#124845)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00bef00f64a7 to 4f86a05ac932 (5 revisions) (flutter/flutter#124841)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from ad222b0c93b9 to 00bef00f64a7 (1 revision) (flutter/flutter#124837)
2023-04-14 andrewrkolos@gmail.com [flutter_tools] Reorganize android_studio_test.dart (flutter/flutter#124834)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from ce7be0093399 to ad222b0c93b9 (1 revision) (flutter/flutter#124832)
2023-04-14 magder@google.com Remove Finder extended attributes in build target before code signing iOS frameworks (flutter/flutter#123896)
2023-04-14 kevmoo@users.noreply.github.com flutter-tool, web: update HTML template serviceWorkerVersion to be const (flutter/flutter#124826)
2023-04-14 tessertaha@gmail.com Fix `CupertinoContextMenu` throws exception on route animation (flutter/flutter#124785)
2023-04-14 kevmoo@users.noreply.github.com flutter-tool: enum cleanup (flutter/flutter#124760)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1289f4b513ef to ce7be0093399 (1 revision) (flutter/flutter#124825)
2023-04-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.1 to 3.5.2 (flutter/flutter#124822)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2ff14d733daa to 1289f4b513ef (2 revisions) (flutter/flutter#124824)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb3e7d52ebbc to 2ff14d733daa (1 revision) (flutter/flutter#124820)
2023-04-13 reidbaker@google.com i123643 print java version gradle (flutter/flutter#123644)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 496543715bdb to eb3e7d52ebbc (3 revisions) (flutter/flutter#124816)
2023-04-13 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#124709)
2023-04-13 21270878+elliette@users.noreply.github.com [flutter_tools] Disable flaky `output_web_test` test case (flutter/flutter#124257)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 26eddb64e8ea to 496543715bdb (1 revision) (flutter/flutter#124812)
2023-04-13 tessertaha@gmail.com Refactor `SliverAppBar.medium` & `SliverAppBar.large` to fix several issues (flutter/flutter#122542)
2023-04-13 jmccandless@google.com Improve the docs around the TextSelectionHandleControls deprecations (flutter/flutter#123827)
2023-04-13 engine-flutter-autoroll@skia.org Roll Packages from fe5615f to d01f4ea (5 revisions) (flutter/flutter#124795)
2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 81a57d24e62a to 26eddb64e8ea (1 revision) (flutter/flutter#124794)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] serviceWorkerVersion to be const
2 participants