这是indexloc提供的服务，不要输入任何密码
Skip to content

Revert "Fix scrolling in the Drawer and NavigationDrawer triggers AppBar's scrolledUnderElevation" #124226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Revert "Fix scrolling in the Drawer and NavigationDrawer triggers AppBar's scrolledUnderElevation" #124226

merged 1 commit into from
Apr 5, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 5, 2023 •
edited
Loading

Reverts #122600

Replaces #124187

Closes #123782

@Piinks
Revert "Fix scrolling in the Drawer and NavigationDrawer triggers…
97624b1 
… AppBar's scrolledUnderElevation (#122600)"

This reverts commit 6e04bdd.
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 5, 2023
justinmc
justinmc approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM 👍

@Piinks Piinks added revert Autorevert PR (with "Reason for revert:" comment) autosubmit Merge PR when tree becomes green via auto submit App labels Apr 5, 2023
@auto-submit auto-submit bot merged commit 0cfcdee into master Apr 5, 2023
@auto-submit auto-submit bot deleted the revert-122600-fix_drawers_scrollUnderElevation branch April 5, 2023 16:10
@auto-submit auto-submit bot mentioned this pull request Apr 5, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
0cfcdee Revert "Fix scrolling in the Drawer and NavigationDrawer …
faa01c2 
…triggers AppBar's scrolledUnderElevation" (flutter/flutter#124226)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@Piinks @exaby73
Revert "Fix scrolling in the Drawer and NavigationDrawer triggers…
27d5a15 
… AppBar's scrolledUnderElevation" (flutter#124226)

Revert "Fix scrolling in the  `Drawer` and `NavigationDrawer` triggers AppBar's scrolledUnderElevation"
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
0cfcdee Revert "Fix scrolling in the Drawer and NavigationDrawer …
449fbf8 
…triggers AppBar's scrolledUnderElevation" (flutter/flutter#124226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
0cfcdee Revert "Fix scrolling in the Drawer and NavigationDrawer …
d2672c0 
…triggers AppBar's scrolledUnderElevation" (flutter/flutter#124226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

~10% regression in stock layout iteration microbenchmark
3 participants
@Piinks @justinmc @fluttergithubbot