这是indexloc提供的服务,不要输入任何密码
Skip to content

Hyperlink dart docs around BinaryMessenger deprecations #123798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

goderbauer
Copy link
Member

The underlying issue (dart-lang/dartdoc#2033) is marked as fixed.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 30, 2023
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #123798 at sha d075e35

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 30, 2023
@goderbauer
Copy link
Member Author

skia-golden reports a 0 pixel diff on an image. That's very odd: This is a doc-only change and the reported diff is zero?

@Piinks
Copy link
Contributor

Piinks commented Mar 30, 2023

skia-golden reports a 0 pixel diff on an image. That's very odd: This is a doc-only change and the reported diff is zero?

FYI @LeandroLovisolo Updated https://bugs.chromium.org/p/skia/issues/detail?id=14004 with the details of this.

@goderbauer
Copy link
Member Author

I approved the 0 pixel diff.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@auto-submit auto-submit bot merged commit 293114a into flutter:master Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
Hyperlink dart docs around BinaryMessenger deprecations
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@goderbauer goderbauer deleted the hyperlink branch July 13, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants