Improve the format in asset_bundle.dart
#126229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
dnfield
approved these changes
May 8, 2023
dnfield
approved these changes
May 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 9, 2023
flutter/flutter@4ed1c92...8c5a1ea 2023-05-08 kevmoo@users.noreply.github.com tool/web: tiniest tweak to wasm help content (flutter/flutter#126284) 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9184ce4ffa0 to 8d3a8162b3ab (7 revisions) (flutter/flutter#126288) 2023-05-08 5236035+fzyzcjy@users.noreply.github.com Fix that `flutter test` does not understand `concurrency` (flutter/flutter#125942) 2023-05-08 5236035+fzyzcjy@users.noreply.github.com Fix that `flutter test` does not understand `concurrency` (flutter/flutter#125942) 2023-05-08 github@alexv525.com Improve the format in `asset_bundle.dart` (flutter/flutter#126229) 2023-05-08 5236035+fzyzcjy@users.noreply.github.com Tiny cleanup for Navigator code (without introducing dependency) (flutter/flutter#125628) 2023-05-08 50433979+negotoyolo@users.noreply.github.com [Refactor] Fix style in example (flutter/flutter#126191) 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8e9ac63fd95 to d9184ce4ffa0 (2 revisions) (flutter/flutter#126279) 2023-05-08 737941+loic-sharma@users.noreply.github.com [Tool] Output help on 'flutter pub' (flutter/flutter#126211) 2023-05-08 jacksongardner@google.com Always use `--concurrency=1` for web tests. (flutter/flutter#126179) 2023-05-08 42216813+eliasyishak@users.noreply.github.com Add `--verbose` flags for flakey tests (flutter/flutter#126162) 2023-05-08 engine-flutter-autoroll@skia.org Roll Packages from a0f8fd8 to 4800d65 (2 revisions) (flutter/flutter#126269) 2023-05-08 reidbaker@google.com Test AGP 8.0 using java 17 (flutter/flutter#125323) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter@4ed1c92...8c5a1ea 2023-05-08 kevmoo@users.noreply.github.com tool/web: tiniest tweak to wasm help content (flutter/flutter#126284) 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9184ce4ffa0 to 8d3a8162b3ab (7 revisions) (flutter/flutter#126288) 2023-05-08 5236035+fzyzcjy@users.noreply.github.com Fix that `flutter test` does not understand `concurrency` (flutter/flutter#125942) 2023-05-08 5236035+fzyzcjy@users.noreply.github.com Fix that `flutter test` does not understand `concurrency` (flutter/flutter#125942) 2023-05-08 github@alexv525.com Improve the format in `asset_bundle.dart` (flutter/flutter#126229) 2023-05-08 5236035+fzyzcjy@users.noreply.github.com Tiny cleanup for Navigator code (without introducing dependency) (flutter/flutter#125628) 2023-05-08 50433979+negotoyolo@users.noreply.github.com [Refactor] Fix style in example (flutter/flutter#126191) 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8e9ac63fd95 to d9184ce4ffa0 (2 revisions) (flutter/flutter#126279) 2023-05-08 737941+loic-sharma@users.noreply.github.com [Tool] Output help on 'flutter pub' (flutter/flutter#126211) 2023-05-08 jacksongardner@google.com Always use `--concurrency=1` for web tests. (flutter/flutter#126179) 2023-05-08 42216813+eliasyishak@users.noreply.github.com Add `--verbose` flags for flakey tests (flutter/flutter#126162) 2023-05-08 engine-flutter-autoroll@skia.org Roll Packages from a0f8fd8 to 4800d65 (2 revisions) (flutter/flutter#126269) 2023-05-08 reidbaker@google.com Test AGP 8.0 using java 17 (flutter/flutter#125323) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found these extra intents and the very long line which might be improved.
Related git blame: https://github.com/flutter/flutter/blame/master/packages/flutter/lib/src/services/asset_bundle.dart#L337.
Pre-launch Checklist
///).