这是indexloc提供的服务，不要输入任何密码
Skip to content

Add FocusNode, onFocusChange, and autofocus to CupertinoSwitch #126684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

Add FocusNode, onFocusChange, and autofocus to CupertinoSwitch #126684

merged 1 commit into from
May 12, 2023

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 12, 2023 •
edited
Loading

fixes #126679

Description

Control cupertino widgets like CupertinoCheckbox and CupertinoRadio have focusNode and autofocus, while these are missing in CupertinoSwitch.

This is blocking #126637
(switch.dart currently maintains its focus node for CupertinoSwitch when using Switch.adaptive which causes a bug)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels May 12, 2023
@TahaTesser TahaTesser mentioned this pull request May 12, 2023
Merged
8 tasks
@TahaTesser TahaTesser requested a review from HansMuller May 12, 2023 16:36
MitchellGoodwin
MitchellGoodwin approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot merged commit b9e3aef into flutter:master May 12, 2023
@TahaTesser TahaTesser deleted the cupertino_switch_focus_node branch May 12, 2023 17:33
auto-submit bot pushed a commit that referenced this pull request May 12, 2023
@TahaTesser
Fix focus behavior and provided thumb and focus color aren't applied …
96dae5e 
…to Cupertino variant of `Switch.adaptive` (#126688)

fixes #126637
fixes #126669

##  ~~To be merged after #126684

### Description

1.  Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus.
2.  Fix `thumbColor` & `focusColor` aren't applied.

### Before
Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied.

https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a

### After
Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied.

https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c
@HansMuller HansMuller mentioned this pull request May 12, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
6d31cbd 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
f49958e 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
8aafe7c 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
fb27e4e 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
301a1b9 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
a1ae4c9 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
eb49ad2 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
556dff3 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
acd1626 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
95b36cd 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
1b471d3 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
86cc025 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
cc5a483 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
47be5d7 
…noSwitch` (flutter/flutter#126684)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
c40849a 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
86e1aa4 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
17c9f3b 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
d9936bd 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
232b527 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
becfe65 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
75db372 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
cee8faa 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
cc38612 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
b78d50f 
…noSwitch` (flutter/flutter#126684)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@TahaTesser
Add FocusNode, onFocusChange, and autofocus to CupertinoSwitch (
86b96d2 
flutter#126684)

fixes flutter#126679 

### Description
Control cupertino widgets like `CupertinoCheckbox` and `CupertinoRadio` have `focusNode` and `autofocus`, while these are missing in `CupertinoSwitch`.

This is blocking flutter#126637 
(`switch.dart` currently maintains its focus node for `CupertinoSwitch` when using `Switch.adaptive` which causes a bug)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@TahaTesser
Fix focus behavior and provided thumb and focus color aren't applied …
a7043f9 
…to Cupertino variant of `Switch.adaptive` (flutter#126688)

fixes flutter#126637
fixes flutter#126669

##  ~~To be merged after flutter#126684

### Description

1.  Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus.
2.  Fix `thumbColor` & `focusColor` aren't applied.

### Before
Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied.

https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a

### After
Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied.

https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
4f58bf3 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
b0a80f8 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
6966c1e 
…noSwitch` (flutter/flutter#126684)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
b9e3aef Add FocusNode, onFocusChange, and autofocus to `Cuperti…
0ef8796 
…noSwitch` (flutter/flutter#126684)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CupertinoSwitch is missing focusNode, onFocusChange and autofocus
3 participants
@TahaTesser @MitchellGoodwin @Piinks