这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove alternate axis assertion from StretchingOverscrollIndicator #120734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2023
Merged

Remove alternate axis assertion from StretchingOverscrollIndicator #120734

merged 2 commits into from
Feb 21, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 15, 2023

Fixes #120733
2D Scrolling proposal: flutter.dev/go/2D-Foundation

In preparation for 2D scrolling, this removes an assertion from the StretchingOverscrollIndicator when it receives a notification from another axis. It is already configured to only apply in one axis, and so now it will just do nothing.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 15, 2023
Piinks
Piinks commented Feb 15, 2023
View reviewed changes
@Piinks Piinks requested a review from guidezpl February 17, 2023 19:42
guidezpl
guidezpl approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@Piinks Piinks added f: material design flutter/packages/flutter/material repository. autosubmit Merge PR when tree becomes green via auto submit App labels Feb 21, 2023
@auto-submit auto-submit bot merged commit 4acbe97 into flutter:master Feb 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
4acbe9706 Remove alternate axis assertion from StretchingOverscrollIn…
3e5cc61 
…dicator (flutter/flutter#120734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
4acbe9706 Remove alternate axis assertion from StretchingOverscrollIn…
0e853dc 
…dicator (flutter/flutter#120734)
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4acbe9706 Remove alternate axis assertion from StretchingOverscrollIn…
dee2a91 
…dicator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
1613b31 
…cator (flutter/flutter#120734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
49c16a4 
…cator (flutter/flutter#120734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
9cb0aab 
…cator (flutter/flutter#120734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
b9f5127 
…cator (flutter/flutter#120734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
32fc162 
…cator (flutter/flutter#120734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
b6657fa 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
6d13c80 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
2ccba93 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
a79deba 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
c55f530 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
0213175 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
18b98fe 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
edc7ec8 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
d9c4658 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
97030d5 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
ccc54ee 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
b3a67df 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
f99174e 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
c084c2b 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
09fa984 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
5208c54 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
116baab 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
2326b5a 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
f496ca7 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
b862c47 
…cator (flutter/flutter#120734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4acbe97 Remove alternate axis assertion from StretchingOverscrollIndi…
db39a88 
…cator (flutter/flutter#120734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StretchingOverscrollIndicator asserts against alternate notification axes
2 participants
@Piinks @guidezpl