Remove mocks from compile_expression_test #78092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Mar 13, 2021
| writes.clear(); | ||
| } | ||
|
|
||
| String getAndClear() { |
There was a problem hiding this comment.
Adopted from
flutter/packages/flutter_tools/test/src/mocks.dart
Lines 220 to 224 in 807bb29
I could be convinced that the clear method is unnecessary, but getting the string is convenient.
jmagman
commented
Mar 13, 2021
Comment on lines
-59
to
-61
| stdErrStreamController = StreamController<String>(); | ||
| when(mockFrontendServerStdErr.transform<String>(any)) | ||
| .thenAnswer((Invocation invocation) => stdErrStreamController.stream); |
There was a problem hiding this comment.
This extra MockStream redirection was unnecessary, directly look up mockFrontendServer.stderr to the stdErrStreamController StreamController.
|
This pull request is not suitable for automatic merging in its current state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
compile_expression_testreplaceMockStdInwithMemoryIOSink. Add convenience methods onMemoryIOSinkto easily get and clear the string written to stdin, and adopt the new methods in a few places.Part of #71511