这是indexloc提供的服务,不要输入任何密码
Skip to content

Allow local networking Info.plist insertion to fail #78085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 13, 2021

Very occasionally Xcode hasn't created an Info.plist by the time the "Thin Binary" script phase runs, which currently causes the build to fail. My guess is that Xcode is parallelizing the steps and the script phase runs right before Info.plist processing, though I'm not 100% sure why this happens.

Instead, allow the insertion to fail, knowing that it will always succeed on a second run (because the last run's Info.plist still exists). The VM service URL won't be published in the app, which means flutter attach won't work until the app is built a second time. #64988

Prefer the rarer flutter attach failing than a normal build or run.

Fixes #70422

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Mar 13, 2021
@jmagman jmagman self-assigned this Mar 13, 2021
@google-cla google-cla bot added the cla: yes label Mar 13, 2021
@jmagman jmagman requested a review from xster March 13, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
3 participants