[flutter_tools] remove reference to flutter tool test from user generated gitignore #62926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, wrong Chris! 🥇 |
| @@ -39,6 +39,3 @@ app.*.symbols | |||
|
|
|||
| # Obfuscation related | |||
| app.*.map.json | |||
|
|
|||
| # Exceptions to above rules. | |||
| !/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages | |||
There was a problem hiding this comment.
I'm a little confused. Will this path appear in a user's app?
There was a problem hiding this comment.
this was a test in the flutter repo that we checked in a .packages file for, there was an exception in our gitignore
There was a problem hiding this comment.
Oh I'm sorry, it's been so long since I coded I forgot how to read a diff...
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are user-generated files, they should not gitignore flutter_tools test dependencies.
This was added in #21192 (according to gblame) but I think that was a mistake that took some flutter tool specific ignores