Add onAppPrivateCommand to TextField #62712
Conversation
|
@goderbauer @justinmc @xster Please take a look. |
| @@ -26,40 +27,53 @@ void main() { | |||
| TextInput.setChannel(SystemChannels.textInput); | |||
| }); | |||
|
|
|||
| test('text input client handler responds to reattach with setClient', () async { | |||
There was a problem hiding this comment.
I've ran "flutter format" to format this file.
There was a problem hiding this comment.
The flutter framework does not use use formatter, see https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#formatting. Can you please undo the unrelated format changes?
There was a problem hiding this comment.
Approach looks fine, I leave it to @justinmc for the final review.
| @@ -1030,6 +1034,9 @@ class EditableText extends StatefulWidget { | |||
| /// {@end-tool} | |||
| final ValueChanged<String> onSubmitted; | |||
|
|
|||
| /// Called when receives the app private command. | |||
There was a problem hiding this comment.
Called when the result of an app private command is received?
|
I'm also not having any luck getting these last tests to go green. @guolinaileen could you try merging in master again? It looks like an infrastructure problem ( |
f070b44 to
9b4f3be
Compare
fc8d0ed to
6de0b08
Compare
|
Looks like the tests are passing! This will be merged when our build is fixed. |
Thanks, Justin! |
| /// {@template flutter.widgets.editableText.onAppPrivateCommand} | ||
| /// Called when the result of an app private command is received. | ||
| /// {@endtemplate} | ||
| final AppPrivateCommandCallback onAppPrivateCommand; |
There was a problem hiding this comment.
Any chance we can have this documentation elaborated? It doesn't really follow our style guide, which requires that documentation be more detailed than could be guessed just from the name. :-)
There was a problem hiding this comment.
Good call, I'll open a quick PR to elaborate on this.
Description
Add onAppPrivateCommand to TextField
Related Issues
This PR is part of introducing sendAppPrivateCommand and onAppPrivateCommand APIs.
Tests
I added the following tests:
TextInputClient performPrivateCommand method is called
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.