[flutter_tools] deflake integration tests by running single isolate #62534
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
LGTM.
Is this a temporary debugging change, or if it works a fix? This may affect @godofredoc benchmarking test run time.
|
Also, were we running integration tests in parallel? Or where the extra isolates just helpers? |
|
I'm not sure if it is a fix, I'll keep monitoring them. We were running the tests in parallel, I could see whether this could cause issues specifically with the lockfile, or other resources that end up shared, like the tester binary |
|
Landing to help green the tree |
…lutter#62534) There are some occasional difficult to repro flakes on the tool integration tests. Try running only a single isolate to simplify the environment a bit.
…lutter#62534) There are some occasional difficult to repro flakes on the tool integration tests. Try running only a single isolate to simplify the environment a bit.
Description
There are some occasional difficult to repro flakes on the tool integration tests. Try running only a single isolate to simplify the environment a bit.