migrate animation to nullsafety #62485

a14n · 2020-07-29T09:57:10Z

Description

NNBD migration for animation

Related Issues

Flutter framework null safety migration dart-lang/sdk#40146

Tests

I added the following tests:

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

fluttergithubbot · 2020-07-29T09:57:13Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer · 2020-07-29T17:39:19Z

packages/flutter/lib/src/animation/animation_controller.dart

@@ -414,22 +413,22 @@ class AnimationController extends Animation<double>
  /// and the most recent tick of the animation.
  ///
  /// If the controller is not animating, the last elapsed duration is null.
-  Duration get lastElapsedDuration => _lastElapsedDuration;
-  Duration _lastElapsedDuration;
+  Duration get lastElapsedDuration => _lastElapsedDuration!;


This is conflicting with the doc comment above it.

goderbauer

LGTM

datayeah · 2020-07-30T17:55:59Z

I now get "The named parameter 'vsync' isn't defined." when trying to use an AnimationController.
AnimationController( duration: const Duration(milliseconds: 800),vsync: this)

Do i have to change my code or is this broken now?

a14n · 2020-07-30T19:35:14Z

vsync param is still here https://github.com/flutter/flutter/pull/62485/files#diff-82a88b0b4aa73ca8c85c9fc068be95b6R242 .
This issue may be an issue regarding null-safety handling in your project. Is there a public repo reproducing the issue?

LasseRosenow · 2020-07-30T19:44:14Z

Its probably because the analyzer does not understand the "required" keyword? which was @required before?

datayeah · 2020-07-30T19:44:50Z

@a14n My IDE (Android Studio 4.0.1) tells me that vsync does not exist and marks this as an error. It suggests adding the vsync parameter with label "TickerProvider:" instead of "vsync:". Fun fact: It compiles when using "vsync:", and it fails to compile if i use the suggested "TickerProvider:" label. I ran "flutter clean" but it doesnt change. I will try to investigate further...

datayeah · 2020-07-30T19:47:10Z

Its probably because the analyzer does not understand the "required" keyword? which was @required before?

yes, if i temporarily change it back to "@required" in the flutter sources, the vsync param is "detected" by the IDE, but then it crashes due to other changes that were made.

a14n · 2020-07-30T19:48:07Z

Can you try to run flutter analyze directly?

datayeah · 2020-07-30T19:49:08Z

No issues found! (ran in 12.7s;)

a14n · 2020-07-30T19:50:37Z

So it looks like your IDE uses a version of Dart that is not the one packaged with Flutter.

datayeah · 2020-07-30T19:54:17Z

Dart SDK version: 2.10.0-1.0.dev.flutter-24c7666def (be) (Wed Jul 22 13:22:07 2020 +0000) on "macos_x64"
I will try to sort this out, seems like it's more an IDE issue than a flutter issue. Thanks for the fast reply! (and for contributing to the framework:)

datayeah · 2020-07-30T20:24:47Z

Okay, to complete this and (maybe) help others:
The issue disappeared after restarting the IDE.
Note to self: Restart the IDE after "flutter upgrade".

thisisgit · 2020-08-07T09:17:01Z

@a14n Came from #62574 and just wondering the difference between required vs. @required?
Is it something that we all need to be prepared for the future release?

a14n · 2020-08-10T19:54:52Z

required has the same meaning in nullsafety as @required before nullsafety. See https://dart.dev/null-safety/understanding-null-safety#required-named-parameters

Is it something that we all need to be prepared for the future release?

As nullsafety is available behind an experimental flag I would not recommand to migrate your code for now.

* migrate animation to nullsafety * nullable tween * fix generic type issue * address review comment

migrate animation to nullsafety

f86992f

fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 29, 2020

googlebot added the cla: yes label Jul 29, 2020

nullable tween

8892155

a14n force-pushed the nnbd-animation branch from 79d227c to 8892155 Compare July 29, 2020 14:22

a14n requested a review from goderbauer July 29, 2020 14:54

fix generic type issue

fb2aadb

goderbauer reviewed Jul 29, 2020

View reviewed changes

address review comment

a8b7657

goderbauer approved these changes Jul 29, 2020

View reviewed changes

a14n added the waiting for tree to go green label Jul 29, 2020

a14n merged commit a7e868d into flutter:master Jul 29, 2020

a14n deleted the nnbd-animation branch July 29, 2020 20:00

thisisgit mentioned this pull request Aug 10, 2020

The named parameter 'vsync' isn't defined. #62574

Closed

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020

migrate animation to nullsafety (flutter#62485)

964ef91

* migrate animation to nullsafety * nullable tween * fix generic type issue * address review comment

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

migrate animation to nullsafety (flutter#62485)

6025fa8

* migrate animation to nullsafety * nullable tween * fix generic type issue * address review comment

GrahamDi mentioned this pull request Oct 2, 2020

AnimationController : The named parameter 'vsync' isn't defined. #63486

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021

migrate animation to nullsafety #62485

migrate animation to nullsafety #62485

Uh oh!

Conversation

a14n commented Jul 29, 2020

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

fluttergithubbot commented Jul 29, 2020

Uh oh!

goderbauer Jul 29, 2020

Choose a reason for hiding this comment

Uh oh!

a14n Jul 29, 2020

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

datayeah commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

a14n commented Jul 30, 2020

Uh oh!

LasseRosenow commented Jul 30, 2020

Uh oh!

datayeah commented Jul 30, 2020

Uh oh!

datayeah commented Jul 30, 2020

Uh oh!

a14n commented Jul 30, 2020

Uh oh!

datayeah commented Jul 30, 2020

Uh oh!

a14n commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datayeah commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datayeah commented Jul 30, 2020

Uh oh!

thisisgit commented Aug 7, 2020

Uh oh!

a14n commented Aug 10, 2020

Uh oh!

Uh oh!

datayeah commented Jul 30, 2020 •

edited

Loading

a14n commented Jul 30, 2020 •

edited

Loading

datayeah commented Jul 30, 2020 •

edited

Loading