这是indexloc提供的服务,不要输入任何密码
Skip to content

Remove flaky flag for flutter_gallery_ios__transition_perf #62348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

keyonghan
Copy link
Contributor

Description

Flaky issue has been fixed for flutter_gallery_ios__transition_perf. Removing the flaky flag.

Related Issues

#62081

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 27, 2020
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan force-pushed the remove_flaky_flag_benchmark branch from 624e9c0 to 8516c66 Compare July 28, 2020 16:28
@jmagman
Copy link
Member

jmagman commented Jul 28, 2020

Screen Shot 2020-07-28 at 10 44 27 AM

@keyonghan This still isn't looking healthy...

@keyonghan
Copy link
Contributor Author

Yeah, that's true. Just noticed there is still system dialog happening, probably related. With Tong's PR to dismiss dialogs before running test, let's see if things get better.

@keyonghan keyonghan force-pushed the remove_flaky_flag_benchmark branch from 8516c66 to 0cefe94 Compare July 30, 2020 19:56
@keyonghan keyonghan merged commit 4f09f2c into flutter:master Jul 31, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
@keyonghan keyonghan deleted the remove_flaky_flag_benchmark branch February 8, 2022 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants