这是indexloc提供的服务，不要输入任何密码
Skip to content

Increase the number of shards for web tests #62623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2020
Merged

Increase the number of shards for web tests #62623

merged 2 commits into from
Aug 4, 2020

Conversation

nturgut
Copy link
Contributor

@nturgut nturgut commented Jul 30, 2020 •
edited
Loading

Description

Increasing the number of web_shards. Similar change for engine: flutter/engine#20164

Related Issues

#62510

Tests

Running on cirrus ci.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

no.

@nturgut nturgut requested a review from tvolkert July 30, 2020 23:18
@nturgut nturgut mentioned this pull request Jul 30, 2020
Merged
7 tasks
@tvolkert
Copy link
Contributor

How does increasing the shards help?

@nturgut
Copy link
Contributor Author

nturgut commented Jul 30, 2020

How does increasing the shards help?

As mentioned in the issue, dart team encountered this problem during head, head, head tests: #61462 Increasing the number of shards worked for them.

I'm not familiar with ./dev/bots/test.dart and it's connection to Chrome, I trying my chances here first :)

@nturgut
Copy link
Contributor Author

nturgut commented Jul 30, 2020

How does increasing the shards help?

I forgot to mention, these are some other related issues from Chrome, with the same output. This looks like a race condition, therefore I hope if we reduce the number of tests per shard it can help.

https://bugs.chromium.org/p/chromium/issues/detail?id=1091689
https://bugs.chromium.org/p/chromium/issues/detail?id=1106485

@tvolkert
Copy link
Contributor

Can you add a TODO that references the right bugs to lower the shards back down once the underlying issue is fixed?

@nturgut
Copy link
Contributor Author

nturgut commented Jul 31, 2020

Looks like it didn't help. The engine one one passed without failing but for this one, web-shard-1 failed with the same error:

01:52 +280 ~7 -1: loading /tmp/flutter sdk/packages/flutter/test/widgets/clip_test.dart [E]                                                                                                            
  Failed to load "/tmp/flutter sdk/packages/flutter/test/widgets/clip_test.dart":
  Unable to connect to Chrome debug port: 43765
   SocketException: OS Error: Connection refused, errno = 111, address = localhost, port = 39980
  package:flutter_tools/src/base/common.dart 14:3                throwToolExit
  package:flutter_tools/src/web/chrome.dart 302:9                ChromiumLauncher._connect
  ===== asynchronous gap ===========================
  dart:async/future.dart 279:46                                  new Future.error
  package:test_core/src/runner/loader.dart 246:26                Loader.loadFile.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1129:19                                   _CustomZone.registerBinaryCallback
  dart:async-patch/async_patch.dart 94:8                         _asyncErrorWrapperHelper
  package:test_core/src/runner/loader.dart                       Loader.loadFile.<fn>
  package:test_core/src/runner/load_suite.dart 98:31             new LoadSuite.<fn>.<fn>
  package:test_core/src/runner/load_suite.dart 108:8             new LoadSuite.<fn>
  package:test_api/src/backend/invoker.dart 229:15               Invoker.waitForOutstandingCallbacks.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:test_api/src/backend/invoker.dart 226:5                Invoker.waitForOutstandingCallbacks
  package:test_api/src/backend/invoker.dart 381:17               Invoker._onRun.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1121:19                                   _CustomZone.registerUnaryCallback
  dart:async-patch/async_patch.dart 83:23                        _asyncThenWrapperHelper
  package:test_api/src/backend/invoker.dart                      Invoker._onRun.<fn>.<fn>.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:test_api/src/backend/invoker.dart 368:9                Invoker._onRun.<fn>.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:test_api/src/backend/invoker.dart 148:7                Invoker.guard
  package:test_api/src/backend/invoker.dart 411:15               Invoker._guardIfGuarded
  package:test_api/src/backend/invoker.dart 367:7                Invoker._onRun.<fn>
  package:stack_trace/src/chain.dart 102:24                      Chain.capture.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:stack_trace/src/chain.dart 100:12                      Chain.capture
  package:test_api/src/backend/invoker.dart 366:11               Invoker._onRun
  package:test_api/src/backend/live_test_controller.dart 152:11  LiveTestController.run
  dart:async/future.dart 201:37                                  new Future.microtask.<fn>
  dart:async/zone.dart 1182:47                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 997:7                                     _CustomZone.runGuarded
  dart:async/zone.dart 1037:23                                   _CustomZone.bindCallbackGuarded.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 997:7                                     _CustomZone.runGuarded
  dart:async/zone.dart 1037:23                                   _CustomZone.bindCallbackGuarded.<fn>
  dart:async/schedule_microtask.dart 41:21                       _microtaskLoop
  dart:async/schedule_microtask.dart 50:5                        _startMicrotaskLoop
  dart:isolate-patch/isolate_patch.dart 118:13                   _runPendingImmediateCallback
  dart:isolate-patch/timer_impl.dart 404:11                      _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 428:5                       _Timer._handleMessage
  dart:core-patch/function.dart                                  _Closure.call
  dart:isolate-patch/isolate_patch.dart 168:12                   _RawReceivePortImpl._handleMessage

@nturgut
Copy link
Contributor Author

nturgut commented Aug 3, 2020

@tvolkert I merged the mirror PR of this on Friday. The tests didn't fail (for 12 shards) in the last three days on the engine side. It was failing on every other PR before that. Shall I merge this change for the time being?

I'll do the fix Chrome team suggests once I hear from them.

@goderbauer goderbauer added platform-web Web applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Aug 3, 2020
tvolkert
tvolkert approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nturgut nturgut merged commit 31ee51a into flutter:master Aug 4, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@Pragya007
Increase the number of shards for web tests (flutter#62623)
eba602b 
* increase the number of shards for web tests

* update comments
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
Increase the number of shards for web tests (flutter#62623)
1f98cf7 
* increase the number of shards for web tests

* update comments
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tvolkert tvolkert tvolkert approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. platform-web Web applications specifically team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nturgut @tvolkert @goderbauer @googlebot