这是indexloc提供的服务,不要输入任何密码
Skip to content

Add LayoutBuilder example #61948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Add LayoutBuilder example #61948

merged 7 commits into from
Jul 28, 2020

Conversation

songyiYu
Copy link
Contributor

@songyiYu songyiYu commented Jul 21, 2020

Description

Add LayoutBuild basic sample code.

Related Issues

Fixes #15467

Tests

No need test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 21, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer
Copy link
Member

Also, the analyzer is unhappy with this: https://github.com/flutter/flutter/pull/61948/checks?check_run_id=893900731

Can you please fix that? Thanks.

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation labels Jul 21, 2020
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs-linux check is failing for a reason unrelated to your change. If you update your branch with the latest from master it should resolve that. :)

@songyiYu
Copy link
Contributor Author

songyiYu commented Jul 27, 2020

@Piinks Thank you for letting me know :) anything more to check??

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution! 🎉
We'll merge this once the tree is green. :)

@fluttergithubbot fluttergithubbot merged commit 0a03d64 into flutter:master Jul 28, 2020
@songyiYu songyiYu deleted the pr branch July 30, 2020 07:40
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LayoutBuilder docs should include a code example
5 participants