-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Add LayoutBuilder example #61948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LayoutBuilder example #61948
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Also, the analyzer is unhappy with this: https://github.com/flutter/flutter/pull/61948/checks?check_run_id=893900731 Can you please fix that? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs-linux check is failing for a reason unrelated to your change. If you update your branch with the latest from master it should resolve that. :)
@Piinks Thank you for letting me know :) anything more to check?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution! 🎉
We'll merge this once the tree is green. :)
Description
Add LayoutBuild basic sample code.
Related Issues
Fixes #15467
Tests
No need test
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.