-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Added the materialTapTargetSize to the OutlineButton Constructor #61086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the materialTapTargetSize to the OutlineButton Constructor #61086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nits
child widget should be trailing named parameter Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
3ff463a
to
dcfd7ea
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@md-weber - I made a trivial fix to the new tests; my feedback (#61086 (comment)) was a little misleading. Should be OK now. Before pushing a commit, it's a good idea to run the tests that you've changed. For example:
Of course, having just changed your test inline, I haven't checked my change, so fingers crossed :-). |
…eber/issue-61061-outline-button-materialTapTargetSize
Hi @HansMuller, I had some issues with Git could you double check that your changes are still intact? |
@md-weber My changes have indeed disappeared. Best if you reapply them: the OutlineButton.icon factory returns a private OutlineButton subclass, so for those tests, you'll need to give the button a key and use |
@HansMuller Fantastic, I added the keys for the two OutlineButton Icons, and it should work now as expected. Unfortunately, I needed to force push because I made a mistake in Rebasing. |
@md-weber - everything looks OK. Hopefully the bots will agree. |
Hi @shihaohong @Piinks it would be fantastic if you could review my very first PR here in the Flutter Repository.
Description
The PR adds the materialTapTargetSize property to the OutlineButton Constructor.
Related Issues
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.