这是indexloc提供的服务,不要输入任何密码
Skip to content

Added the materialTapTargetSize to the OutlineButton Constructor #61086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

md-weber
Copy link
Contributor

@md-weber md-weber commented Jul 8, 2020

Hi @shihaohong @Piinks it would be fantastic if you could review my very first PR here in the Flutter Repository.

Description

The PR adds the materialTapTargetSize property to the OutlineButton Constructor.

Related Issues

Tests

I added the following tests:

  • OutlineButton respects the provided materialTapTargetSize

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 8, 2020
@md-weber md-weber requested a review from HansMuller July 9, 2020 14:19
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

child widget should be trailing named parameter

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong
Copy link
Contributor

framework_tests-libraries-* seems to be failing for reasons unrelated to your PR. Try rebasing/merging your branch with master to see if that fixes the check

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 9, 2020
@md-weber md-weber force-pushed the md-weber/issue-61061-outline-button-materialTapTargetSize branch from 3ff463a to dcfd7ea Compare July 9, 2020 15:11
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 9, 2020
@HansMuller
Copy link
Contributor

@md-weber - I made a trivial fix to the new tests; my feedback (#61086 (comment)) was a little misleading. Should be OK now.

Before pushing a commit, it's a good idea to run the tests that you've changed. For example:

(cd packages/flutter; flutter test test/material/outline_button_test.dart)

Of course, having just changed your test inline, I haven't checked my change, so fingers crossed :-).

…eber/issue-61061-outline-button-materialTapTargetSize
@md-weber
Copy link
Contributor Author

md-weber commented Jul 9, 2020

Hi @HansMuller, I had some issues with Git could you double check that your changes are still intact?

@HansMuller
Copy link
Contributor

@md-weber My changes have indeed disappeared. Best if you reapply them: the OutlineButton.icon factory returns a private OutlineButton subclass, so for those tests, you'll need to give the button a key and use find.byKey.

@md-weber
Copy link
Contributor Author

md-weber commented Jul 9, 2020

@HansMuller Fantastic, I added the keys for the two OutlineButton Icons, and it should work now as expected.

Unfortunately, I needed to force push because I made a mistake in Rebasing.

@HansMuller
Copy link
Contributor

@md-weber - everything looks OK. Hopefully the bots will agree.

@fluttergithubbot fluttergithubbot merged commit c29009b into flutter:master Jul 9, 2020
@md-weber md-weber deleted the md-weber/issue-61061-outline-button-materialTapTargetSize branch July 15, 2020 06:40
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants