这是indexloc提供的服务，不要输入任何密码
Skip to content

Re-land "Tweaking Material Chip a11y semantics to match buttons (#60141)" #61048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

Re-land "Tweaking Material Chip a11y semantics to match buttons (#60141)" #61048

merged 1 commit into from
Jul 10, 2020

Conversation

nscobie
Copy link
Contributor

@nscobie nscobie commented Jul 7, 2020 •
edited
Loading

Description

Re-lands #60141, which was reverted by #60645 due to an unexpected edge case which broke some internal tests.

PR for breaking change doc: flutter/website#4312
Published breaking change doc: https://flutter.dev/docs/release/breaking-changes/material-chip-button-semantics

Related Issues

Tests

See #60141 for details.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Jul 7, 2020
@nscobie nscobie mentioned this pull request Jul 8, 2020
Merged
@nscobie nscobie requested a review from gaaclarke July 8, 2020 00:22
@nscobie nscobie added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: money (g3) labels Jul 8, 2020
gaaclarke
gaaclarke approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is still a draft but looks as good as it did the first time =)

@nscobie nscobie marked this pull request as ready for review July 8, 2020 19:28
@nscobie nscobie self-assigned this Jul 8, 2020
@nscobie nscobie force-pushed the revert-60645-revert-da489c337a654e58b126fa5405a486c56c816383 branch from fe1ca95 to 03bf4e3 Compare July 8, 2020 20:28
@nscobie nscobie requested a review from Piinks as a code owner July 8, 2020 20:28
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 8, 2020
@nscobie nscobie force-pushed the revert-60645-revert-da489c337a654e58b126fa5405a486c56c816383 branch from 03bf4e3 to fe1ca95 Compare July 8, 2020 20:43
@nscobie nscobie removed the request for review from Piinks July 8, 2020 20:45
@nscobie nscobie force-pushed the revert-60645-revert-da489c337a654e58b126fa5405a486c56c816383 branch from fe1ca95 to c9cde5a Compare July 8, 2020 20:57
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 8, 2020
@fluttergithubbot fluttergithubbot merged commit dc0f122 into master Jul 10, 2020
@fluttergithubbot fluttergithubbot deleted the revert-60645-revert-da489c337a654e58b126fa5405a486c56c816383 branch July 10, 2020 21:21
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@nscobie @mingwandroid
Revert "Revert "Tweaking Material Chip a11y semantics to match buttons (
90b9268 
flutter#60141)" (flutter#60645)" (flutter#61048)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

@nscobie nscobie

Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: money (g3) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputChip does not announce any action for a11y on iOS
4 participants
@nscobie @googlebot @gaaclarke @fluttergithubbot