这是indexloc提供的服务，不要输入任何密码
Skip to content

Simplify the animation control for macrobenchmarks test case #60412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 30, 2020
Merged

Simplify the animation control for macrobenchmarks test case #60412

merged 5 commits into from
Jun 30, 2020

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Jun 27, 2020

Description

This is a follow up of #60336, basically doesn't change anything but use animation API in a better way.

Related Issues

N/A

Tests

No because it's a refactoring

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 27, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CareF CareF self-assigned this Jun 27, 2020
@CareF
Copy link
Contributor Author

CareF commented Jun 27, 2020

@liyuqian This actually applies to many in macrobenchmarks where a curve is not necessary at all.

CareF
CareF commented Jun 27, 2020
View reviewed changes
@CareF CareF requested a review from liyuqian June 27, 2020 05:08
@CareF CareF changed the title Simplify the animation control Simplify the animation control for macrobenchmarks test case Jun 27, 2020
@CareF CareF mentioned this pull request Jun 27, 2020
Merged
10 tasks
@CareF CareF requested a review from flar June 27, 2020 12:55
flar
flar requested changes Jun 28, 2020
View reviewed changes
@CareF CareF requested a review from flar June 28, 2020 20:37
flar
flar approved these changes Jun 29, 2020
View reviewed changes
CareF
CareF commented Jun 29, 2020
View reviewed changes
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-commands-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-integration-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_integration_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-0-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-1-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-2-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-3-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-4-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-5-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-6-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-7_last-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_tests-0-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_tests-1_last-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite hostonly_devicelab_tests-0-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite hostonly_devicelab_tests-1-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite firebase_test_lab_tests-1-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite firebase_test_lab_tests-2_last-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-general-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-commands-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-integration-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_tests-0-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_tests-1_last-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite hostonly_devicelab_tests-0-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite hostonly_devicelab_tests-1-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite hostonly_devicelab_tests-2-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite customer_testing-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

flar
flar approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CareF CareF merged commit 59aed97 into flutter:master Jun 30, 2020
@CareF CareF deleted the wiget_contruction_heavy_test branch June 30, 2020 00:20
@kf6gpe kf6gpe mentioned this pull request Jun 30, 2020
Closed
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@CareF @mingwandroid
Simplify the animation control for macrobenchmarks test case (flutter…
38b44e5 
…#60412)

* Simplify the animation control

* Using AnimatedBuilder
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flar flar flar approved these changes

@liyuqian liyuqian Awaiting requested review from liyuqian

Assignees

@CareF CareF

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CareF @fluttergithubbot @flar @googlebot