这是indexloc提供的服务,不要输入任何密码
Skip to content

Localized new strings added in the redesigned Material Time Picker #60096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

rami-a
Copy link
Contributor

@rami-a rami-a commented Jun 23, 2020

Description

The new redesign of the Material Time Picker (#59191) added several new user facing strings that need to be localized. This PR is the first step for that localization. It adds the new strings to the MaterialLocalizations class with english defaults in the DefaultMaterialLocalizations class. The locale .arb files have all been update with the english values for these strings. When the translations are available another PR will be created to complete the process.

Tests

I added the following tests:

  • Tests for all the new strings to localizations_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 23, 2020
@rami-a rami-a requested a review from darrenaustin June 23, 2020 16:03
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM.

@rami-a rami-a force-pushed the l10n-time-picker branch from c0b9045 to d1b4e28 Compare June 23, 2020 19:25
@flutter-github-sync
Copy link

Google testing passed!

1 similar comment
@flutter-github-sync
Copy link

Google testing passed!

Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

@fluttergithubbot fluttergithubbot merged commit 50612db into flutter:master Jun 24, 2020
@rami-a rami-a deleted the l10n-time-picker branch June 24, 2020 17:35
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants