这是indexloc提供的服务，不要输入任何密码
Skip to content

Replace ANDROID_HOME user messages with ANDROID_SDK_ROOT #59867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Replace ANDROID_HOME user messages with ANDROID_SDK_ROOT #59867

merged 1 commit into from
Jun 23, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 19, 2020

Description

Replace remaining user-facing references to deprecated ANDROID_HOME with ANDROID_SDK_ROOT. No behavior changes, just updated user messages.

Related Issues

Another sweep of #39301.
This is still confusing users #59050 (comment)

Tests

Updated tests.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 19, 2020
@jmagman
Copy link
Member Author

jmagman commented Jun 19, 2020

Docs updated at flutter/website#4246

@jmagman jmagman self-assigned this Jun 19, 2020
@jmagman jmagman added the platform-android Android applications specifically label Jun 19, 2020
christopherfujino
christopherfujino approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Contributor

Nice!

@fluttergithubbot fluttergithubbot merged commit 6a2bc26 into flutter:master Jun 23, 2020
@jmagman jmagman deleted the android-sdk branch June 23, 2020 01:55
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Replace ANDROID_HOME user messages with ANDROID_SDK_ROOT (flutter#59867)
a8dd808
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmagman @jonahwilliams @christopherfujino @googlebot @fluttergithubbot