这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix the paste button label in the new version of the filtered text pasting test #59865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

Fix the paste button label in the new version of the filtered text pasting test #59865

merged 1 commit into from
Jun 19, 2020

Conversation

jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jun 19, 2020 •
edited
Loading

This fixes a regression in text_field_test related to #59120

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 19, 2020
goderbauer
goderbauer approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonahwilliams
jonahwilliams approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: add a PR description for future archaeologists

Piinks
Piinks approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think fyi @justinmc

justinmc
justinmc approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks, sorry I missed this one!

@jason-simmons jason-simmons mentioned this pull request Jun 19, 2020
Merged
@christopherfujino christopherfujino mentioned this pull request Jun 19, 2020
Merged
@jason-simmons jason-simmons force-pushed the fix_text_field_filter_paste branch from 9484bca to 551480e Compare June 19, 2020 19:06
@jason-simmons jason-simmons merged commit 4173881 into flutter:master Jun 19, 2020
@GaryQian
Copy link
Contributor

Is it weird that I had the PASTE already in caps in my local clone of the framework before this patch landed? Thus, I was unable to repro this last night?

@GaryQian
Copy link
Contributor

Wait JK, I can't read, it was made lowercase not uppercase. Please ignore my spam.

zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
@jason-simmons @zljj0818
Fix the paste button label in the new version of the filtered text pa…
1fc39b3 
…sting test (flutter#59865)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jason-simmons @mingwandroid
Fix the paste button label in the new version of the filtered text pa…
af5107c 
…sting test (flutter#59865)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken approved these changes

@justinmc justinmc justinmc approved these changes

@goderbauer goderbauer goderbauer approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jason-simmons @GaryQian @cbracken @justinmc @goderbauer @jonahwilliams @Piinks @googlebot @fluttergithubbot