[flutter_driver] make timeline request in chunks #58430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahaog
added a commit
to jiahaog/flutter
that referenced
this pull request
Jun 22, 2020
When `retainPriorEvents` is passed as true, the current behavior still limits timeline events to the timestamp after `traceEvents` is called. This can cause startup events to be missing. This fixes it by passing null to `stopTracingAndDownloadTimeline` for the start and end time. Related: flutter#58430
jiahaog
added a commit
that referenced
this pull request
Jun 23, 2020
When `retainPriorEvents` is passed as true, the current behavior still limits timeline events to the timestamp after `traceEvents` is called. This can cause startup events to be missing. This fixes it by passing null to `stopTracingAndDownloadTimeline` for the start and end time. Related: #58430
|
This seems to significantly reduce our "complex_layout_scroll_perf__devtools_memory maxAdbTotal" benchmark. Although this may not affect the release mode, it's still great to reduce the memory usage in the profile/debug mode. |
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
When `retainPriorEvents` is passed as true, the current behavior still limits timeline events to the timestamp after `traceEvents` is called. This can cause startup events to be missing. This fixes it by passing null to `stopTracingAndDownloadTimeline` for the start and end time. Related: flutter#58430
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work-around large timeline data killing devicelab machines by requesting data in 1 second intervals and combining at the end. Non-breaking change to the driver API.
#57756