这是indexloc提供的服务,不要输入任何密码
Skip to content

InkWell uses MaterialStateMouseCursor and defaults to clickable #58448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jun 1, 2020

Description

This PR adds support for material state mouse cursor to InkWell and InkResponse, and set their default cursors to be MaterialStateMouseCursor.clickable.

During #57628, InkWell and InkResponse were considered a "basic" widget and has a mouse cursor that defaults to defer. This has been found inconvenient when I'm adding cursor support to Flutter Gallery in that I had to add the same line mouseCursor: SystemMouseCursors.click to every occurrence of InkWell. This made me realize it's probably better to let it default to click - or better, clickable.

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.

Tests

I added the following tests:

  • Changed inkwell's tests to include disabled states

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 1, 2020
@dkwingsmt dkwingsmt requested a review from HansMuller June 1, 2020 22:31
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! LGTM

@dkwingsmt dkwingsmt merged commit 0bda633 into flutter:master Jun 2, 2020
@dkwingsmt dkwingsmt deleted the inkwell-click branch June 2, 2020 19:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants