这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove outdated disable_input_output_paths from example project Podfiles #58444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Remove outdated disable_input_output_paths from example project Podfiles #58444

merged 1 commit into from
Jun 2, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 1, 2020

Description

Update release_smoke_test and flutter_gallery integration tests to Podfile template changed in #51453, which removed the #20685 (comment) hack.
examples/platform_view doesn't have any plugins, so remove the Podfile (ideally the tool would do that automatically, see #11819)

Related Issues

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 1, 2020
@jmagman jmagman requested a review from christopherfujino June 1, 2020 21:50
@jmagman jmagman self-assigned this Jun 1, 2020
@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 1, 2020
christopherfujino
christopherfujino approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmagman
jmagman commented Jun 1, 2020
View reviewed changes
dev/integration_tests/flutter_gallery/ios/Runner.xcodeproj/project.pbxproj
Comment on lines +262 to +263
"${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks.sh",
"${PODS_ROOT}/../Flutter/Flutter.framework",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CocoaPods added this, disable_input_output_paths suppresses this behavior.

@fluttergithubbot fluttergithubbot merged commit 8adaea9 into flutter:master Jun 2, 2020
@jmagman jmagman deleted the disable_input_output_paths branch June 2, 2020 17:03
jmagman added a commit that referenced this pull request Jun 2, 2020
@jmagman
Revert "Remove outdated disable_input_output_paths from example proje…
b5733be 
…ct Podfiles (#58444)"

This reverts commit 8adaea9.
@jmagman jmagman mentioned this pull request Jun 2, 2020
Merged
jmagman added a commit that referenced this pull request Jun 2, 2020
@jmagman
Revert "Remove outdated disable_input_output_paths from example proje…
c34d6e2 
…ct Podfiles (#58444)" (#58504)

This reverts commit 8adaea9.
@jmagman jmagman mentioned this pull request Jun 2, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmagman @christopherfujino @googlebot @fluttergithubbot