这是indexloc提供的服务，不要输入任何密码
Skip to content

Run flutter update-packages --force-upgrade. #58104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2020
Merged

Run flutter update-packages --force-upgrade. #58104

merged 4 commits into from
May 29, 2020

Conversation

pennzht
Copy link
Member

@pennzht pennzht commented May 27, 2020 •
edited
Loading

Description

I ran flutter update-packages --force-upgrade, in order to bump up the version of flutter_gallery_assets to 0.2.1, to reconcile with the version used in flutter/gallery.
This PR contains the changes made to all .yaml files after running the command.

This change is required for the following PRs:

I decided to submit this as a separate PR, so that the version changes won't clutter the changes I make for the 2 PRs above.

Related Issues

flutter/gallery#103

Tests

This is a version update. It does not require tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
    • This is a version update. It does not require documentation.
  • All existing and new tests are passing.
    • This is a version update.
    • I only ran tests in packages/flutter/test/. They all passed.
    • tool_tests-commands-{linux,macos,windows} are failing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
    • This is a version update.
    • I only ran tests in packages/flutter/test/. They all passed.
    • tool_tests-commands-{linux,macos,windows} are failing.

@pennzht pennzht requested a review from Piinks as a code owner May 27, 2020 16:02
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 27, 2020
@yjbanov yjbanov requested a review from jonahwilliams May 27, 2020 16:52
@yjbanov
Copy link
Contributor

yjbanov commented May 27, 2020

@jonahwilliams could you please assist @pennzht with this PR? The tools tests are failing to run pub get for some reason.

@jmagman
Copy link
Member

jmagman commented May 27, 2020

The error is

Because test >=1.13.0 <1.14.5 depends on test_api 0.2.15 and every version of flutter_driver from sdk depends on test_api 0.2.16, test >=1.13.0 <1.14.5 is incompatible with flutter_driver from sdk.
So, because flutter_project depends on both flutter_driver any from sdk and test 1.13.0, version solving failed.

@yjbanov
Copy link
Contributor

yjbanov commented May 27, 2020

@jonahwilliams said:

you need to update https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L49
possibly other lines in the pubspec.yaml

@yjbanov
Copy link
Contributor

yjbanov commented May 27, 2020

@jonahwilliams said:

you need to update https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L49
possibly other lines in the pubspec.yaml

@Hixie Shouldn't flutter update-packages --force-upgrade do this automatically?

@jonahwilliams
Copy link
Contributor

no, thats why we have the test

@pennzht
Copy link
Member Author

pennzht commented May 27, 2020

@jonahwilliams

no, thats why we have the test

Thank you very much for your message!
How should we resolve this issue (without breaking more tests)?

HansMuller
HansMuller approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonahwilliams
jonahwilliams approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pennzht pennzht merged commit 03c74eb into flutter:master May 29, 2020
@pennzht pennzht deleted the bump-gallery-assets-version branch May 29, 2020 22:13
@Hixie
Copy link
Contributor

Hixie commented May 29, 2020

If we pin the test package in the Flutter SDK, should we just be depending on the test package as any instead of with a fixed version? It seems like having a fixed version here means that we'll be making life harder on developers to upgrade Flutter later.

@jonahwilliams
Copy link
Contributor

We could also give it a caret ^. I think any dependencies should probably be avoided unless a user is specifically experimenting, so I'd be worried that adding it to the template would precipitate a bad practice

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@clocksmith clocksmith clocksmith approved these changes

@HansMuller HansMuller HansMuller approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pennzht @yjbanov @jmagman @jonahwilliams @Hixie @clocksmith @HansMuller @googlebot @fluttergithubbot