这是indexloc提供的服务，不要输入任何密码
Skip to content

Added Documentation for AnimationController.repeat() #58098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2020
Merged

Added Documentation for AnimationController.repeat() #58098

merged 4 commits into from
Jun 2, 2020

Conversation

VisheshAtWork
Copy link
Contributor

Description

Added Documentation for period argument in AnimationController.repeat() which was not specified previously.

Related Issues

Closes #53255

Tests

No tests. Just added documentation.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label May 27, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@VisheshAtWork
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

goderbauer
goderbauer reviewed May 27, 2020
View reviewed changes
@goderbauer
Copy link
Member

You'll also have to fix the problems identified by the analyzer: https://github.com/flutter/flutter/pull/58098/checks?check_run_id=713481746

@VisheshAtWork
Copy link
Contributor Author

You'll also have to fix the problems identified by the analyzer: https://github.com/flutter/flutter/pull/58098/checks?check_run_id=713481746

Fixed the previous issue. I am new and dont know what the error mentioned here means https://github.com/flutter/flutter/pull/58098/checks?check_run_id=719322983

@VisheshAtWork VisheshAtWork requested a review from goderbauer May 31, 2020 06:57
goderbauer
goderbauer reviewed Jun 1, 2020
View reviewed changes
@VisheshAtWork @goderbauer
Fixed testing error.
fc15c34 
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
goderbauer
goderbauer approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer merged commit df45748 into flutter:master Jun 2, 2020
@VisheshAtWork VisheshAtWork deleted the animation.repeat_docs branch June 3, 2020 04:36
@VisheshAtWork VisheshAtWork restored the animation.repeat_docs branch June 3, 2020 04:36
@VisheshAtWork VisheshAtWork deleted the animation.repeat_docs branch June 3, 2020 04:36
@VisheshAtWork VisheshAtWork restored the animation.repeat_docs branch June 3, 2020 04:36
@VisheshAtWork VisheshAtWork deleted the animation.repeat_docs branch June 3, 2020 04:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnimationController.repeat duration should be documented
4 participants
@VisheshAtWork @fluttergithubbot @googlebot @goderbauer