[flutter_tools] Put a heap size limit on the frontend_server #58039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -648,6 +650,8 @@ class DefaultResidentCompiler implements ResidentCompiler { | |||
| ); | |||
| final List<String> command = <String>[ | |||
| globals.artifacts.getArtifactPath(Artifact.engineDartBinary), | |||
| '--disable-dart-dev', | |||
There was a problem hiding this comment.
nit: add a comment linking to the issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the issues below the frontend_server appears to be requesting large allocations for unknown reasons. This PR puts a limit of 2GB on the frontend_server's old gen heap size. When the limit is reached, or when an allocation request exceeds its size, the frontend_server will fail with an
OutOfMemoryexception rather than hitting aFATALin the VM.Related Issues
#54420
dart-lang/sdk#41862
Tests
I added the following tests:
I added a test that the
KernelCompilerpasses the heap limit flags.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].