[SwitchListTile] adds controlAffinity property #58037
Conversation
|
Looks like the analyzer is complaining about trailing whitespace |
|
Btw, I just realized you're not listed as an AUTHOR on the AUTHORS page. If you want, feel free to add yourself on there since you've been contributing a great deal in the last few months |
Thank you 😄 |
AUTHORS
Outdated
| @@ -56,3 +56,4 @@ Michael Lee <ckmichael8@gmail.com> | |||
| Katarina Sheremet <katarina@sheremet.ch> | |||
| Nicolas Schneider <nioncode+git@gmail.com> | |||
| Mikhail Zotyev <mbixjkee1392@gmail.com> | |||
| Ayush Bherwani <ayush.bherwani1998@gmail.com> | |||
There was a problem hiding this comment.
nit: add a newline to the end of files
| Ayush Bherwani <ayush.bherwani1998@gmail.com> | |
| Ayush Bherwani <ayush.bherwani1998@gmail.com> | |
| @@ -298,4 +298,44 @@ void main() { | |||
| await tester.pump(); | |||
| expect(Focus.of(childKey.currentContext, nullOk: true).hasPrimaryFocus, isFalse); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
This is the trailing whitespace:
There was a problem hiding this comment.
But, isn't that a new line? It feels weird that analyzer is complaining about it.
There was a problem hiding this comment.
It's not the new line. It's the whitespace within the line.
{whitespace}{whitespace}
vs
There was a problem hiding this comment.
I see, thanks for clearing silly doubt @shihaohong.
I'll do the required changes.
Description
Adds
controlAffinityproperty to change the position ofSwitch.Related Issues
Fixes #22134
Tests
I added the following tests:
controlAffinityproperty works as desired and position ofSwitchis changed.controlAffinityworks as desired.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.