这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove invalid local from macos_assemble.sh #58030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

Remove invalid local from macos_assemble.sh #58030

merged 1 commit into from
May 27, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented May 26, 2020

When you run this, bash complains that local is only valid in functions. Gets rid of that extraneous warning.

@dnfield
Remove invalid local from macos_assemble.sh
7b63f15 
When you run this, bash complains that `local` is only valid in functions. Gets rid of that extraneous warning.
@dnfield dnfield requested a review from jonahwilliams May 26, 2020 18:53
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 26, 2020
christopherfujino
christopherfujino approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jonahwilliams
jonahwilliams approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit 98ce4a5 into master May 27, 2020
@dnfield dnfield deleted the dnfield-patch-1 branch May 27, 2020 17:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnfield @christopherfujino @jonahwilliams @googlebot @fluttergithubbot