这是indexloc提供的服务，不要输入任何密码
Skip to content

Prevent building non-android plugins in build aar #58018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2020
Merged

Prevent building non-android plugins in build aar #58018

merged 2 commits into from
May 27, 2020

Conversation

blasten
Copy link

@blasten blasten commented May 26, 2020

Description

Ensures that build aar doesn't link against non-android plugins.

Related Issues

Fixes #57795

Tests

I added the following tests: Updated integration test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 26, 2020
@blasten blasten requested a review from jonahwilliams May 26, 2020 16:08
jonahwilliams
jonahwilliams approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite build_tests-1_last-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman jmagman merged commit 4465ff9 into flutter:master May 27, 2020
@creativecreatorormaybenot
Copy link
Contributor

Will this be avaible on stable?

@blasten
Copy link
Author

blasten commented May 27, 2020

cc @pcsosinski - is it possible to cherry-pick this commit?

@blasten blasten deleted the aar_non_android_plugin branch May 27, 2020 17:15
@pcsosinski
Copy link

https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process

pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request May 28, 2020
Prevent building non-android plugins in build aar (flutter#58018)
c331714
pcsosinski pushed a commit that referenced this pull request May 28, 2020
@LongCatIsLooong @pedromassango
@christopherfujino @jason-simmons @stuartmorgan-g @jmagman
Flutter 1.17.2 cherrypicks (#58050)
5f21edf 
* fix segment hit test behavior (#57461)

* Making DropdownButtonFormField to re-render if parent widget changes (#57037)

* Update DropdownButtonFormField's state if widget updates

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>

* throw more specific toolexit when git fails during upgrade (#57162)

* [flutter_tools] Refresh VM state before executing hot reload (#53960)

* Update engine hash for 1.17.2

* Remove MaterialControls from examples/flutter_view (#57621)

Co-authored-by: Jenn Magder <magder@google.com>

* Prevent building non-android plugins in build aar (#58018)

* Allow FLUTTER_APPLICATION_PATH to be null for misconfigured Xcode projects (#57701)

* Don't import plugins that don't support android in settings.gradle (#54407)

Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
Co-authored-by: Pedro Massango <pedromassango.developer@gmail.com>
Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com>
Co-authored-by: stuartmorgan <stuartmorgan@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flutter module] Flutter_tools/gradle/aar_init_script.gradle' line: 15 - AAR build fail
7 participants
@blasten @fluttergithubbot @creativecreatorormaybenot @pcsosinski @jonahwilliams @jmagman @googlebot