[e2e] make test bindings friendlier to integration tests #58210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
reviewed
May 29, 2020
| if (overrideHttpClient) { | ||
| binding.setupHttpOverrides(); | ||
| } | ||
| _testTextInput = TestTextInput(onCleared: _resetFocusedEditable); |
There was a problem hiding this comment.
should this be inside the if case?
There was a problem hiding this comment.
I'd rather not change this to be nullable - creating it does not automatically alter any global state (until register is called).
There was a problem hiding this comment.
And I've updated TestTextInput in another patch to assert that it's registered for any method that wouldn't make sense in an unregistered context.
|
Thanks for the change, I was still looking at the PR. LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration tests may not want to override testTextInput or HttpClient. This lets binding subclasses for tests achieve that.
Related Issues
Part of #51885
Part of #57623
Tests
I added the following tests:
Test that the default bindings do override HttpClient and register TestTextInput.
Test that custom bindings using the new properties do not override/register.
Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.